From 78a657f6f7d858da4de74bbaa8ba0043c52c5b71 Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Tue, 19 Apr 2022 17:31:58 +0200 Subject: [PATCH] Remove obsolete TODO in getIcebergLiteralValue When the code section was added, the method handled selected types and had implicit fallback. Nowdays, the method must support all types explicitly, and there is no follback behavior. --- .../main/java/io/trino/plugin/iceberg/ExpressionConverter.java | 1 - 1 file changed, 1 deletion(-) diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java index f72f88cac0db..b016d5529bd2 100644 --- a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java +++ b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ExpressionConverter.java @@ -193,7 +193,6 @@ private static Object getIcebergLiteralValue(Type type, Object trinoNativeValue) return (double) trinoNativeValue; } - // TODO: Remove this conversion once we move to next iceberg version if (type instanceof DateType) { return toIntExact(((Long) trinoNativeValue)); }