diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java index 2eaefa4c8e7a..97feb1e44228 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java @@ -594,7 +594,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000, 10))) .build(); - // B table is small enough to be replicated in AUTOMATIC_RESTRICTED mode + // B table is small enough to be replicated according to JOIN_MAX_BROADCAST_TABLE_SIZE limit assertDetermineJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -629,7 +629,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000d * 10000, 10))) .build(); - // B table exceeds AUTOMATIC_RESTRICTED limit therefore it is partitioned + // B table exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit therefore it is partitioned assertDetermineJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -663,23 +663,23 @@ public void testReplicatesWhenSourceIsSmall() int aRows = 10_000; int bRows = 10; - // output size exceeds AUTOMATIC_RESTRICTED limit + // output size exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit PlanNodeStatsEstimate aStatsEstimate = PlanNodeStatsEstimate.builder() .setOutputRowCount(aRows) .addSymbolStatistics(ImmutableMap.of(new Symbol("A1"), new SymbolStatsEstimate(0, 100, 0, 640000d * 10000, 10))) .build(); - // output size exceeds AUTOMATIC_RESTRICTED limit + // output size exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit PlanNodeStatsEstimate bStatsEstimate = PlanNodeStatsEstimate.builder() .setOutputRowCount(bRows) .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000d * 10000, 10))) .build(); - // output size does not exceed AUTOMATIC_RESTRICTED limit + // output size does not exceed JOIN_MAX_BROADCAST_TABLE_SIZE limit PlanNodeStatsEstimate bSourceStatsEstimate = PlanNodeStatsEstimate.builder() .setOutputRowCount(bRows) .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 64, 10))) .build(); - // immediate join sources exceeds AUTOMATIC_RESTRICTED limit but build tables are small + // immediate join sources exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit but build tables are small // therefore replicated distribution type is chosen assertDetermineJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineSemiJoinDistributionType.java b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineSemiJoinDistributionType.java index 94ed8c38bd3c..f6a2885050cd 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineSemiJoinDistributionType.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestDetermineSemiJoinDistributionType.java @@ -239,7 +239,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000, 10))) .build(); - // B table is small enough to be replicated in AUTOMATIC_RESTRICTED mode + // B table is small enough to be replicated according to JOIN_MAX_BROADCAST_TABLE_SIZE limit assertDetermineSemiJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -275,7 +275,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000d * 10000, 10))) .build(); - // B table exceeds AUTOMATIC_RESTRICTED limit therefore it is partitioned + // B table exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit therefore it is partitioned assertDetermineSemiJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -323,7 +323,7 @@ public void testReplicatesWhenSourceIsSmall() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 64, 10))) .build(); - // build side exceeds AUTOMATIC_RESTRICTED limit but source plan nodes are small + // build side exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit but source plan nodes are small // therefore replicated distribution type is chosen assertDetermineSemiJoinDistributionType() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, JoinDistributionType.AUTOMATIC.name()) diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestReorderJoins.java b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestReorderJoins.java index 7563a9eac14f..4934e3fc96db 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestReorderJoins.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestReorderJoins.java @@ -571,7 +571,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000, 10))) .build(); - // B table is small enough to be replicated in AUTOMATIC_RESTRICTED mode + // B table is small enough to be replicated according to JOIN_MAX_BROADCAST_TABLE_SIZE limit assertReorderJoins() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -606,7 +606,7 @@ public void testReplicatesWhenNotRestricted() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000d * 10000, 10))) .build(); - // B table exceeds AUTOMATIC_RESTRICTED limit therefore it is partitioned + // B table exceeds JOIN_MAX_BROADCAST_TABLE_SIZE limit therefore it is partitioned assertReorderJoins() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, AUTOMATIC.name()) .setSystemProperty(JOIN_MAX_BROADCAST_TABLE_SIZE, "100MB") @@ -649,7 +649,7 @@ public void testReorderAndReplicate() .addSymbolStatistics(ImmutableMap.of(new Symbol("B1"), new SymbolStatsEstimate(0, 100, 0, 640000, 10))) .build(); - // A table is small enough to be replicated in AUTOMATIC_RESTRICTED mode + // A table is small enough to be replicated in JOIN_MAX_BROADCAST_TABLE_SIZE mode assertReorderJoins() .setSystemProperty(JOIN_DISTRIBUTION_TYPE, AUTOMATIC.name()) .setSystemProperty(JOIN_REORDERING_STRATEGY, AUTOMATIC.name())