diff --git a/client/trino-client/src/test/java/io/trino/client/auth/external/TestExternalAuthentication.java b/client/trino-client/src/test/java/io/trino/client/auth/external/TestExternalAuthentication.java index 420abb4d9854..9d81a5bf4499 100644 --- a/client/trino-client/src/test/java/io/trino/client/auth/external/TestExternalAuthentication.java +++ b/client/trino-client/src/test/java/io/trino/client/auth/external/TestExternalAuthentication.java @@ -72,7 +72,7 @@ public void testObtainTokenWhenTokenIsNeverAvailable() { RedirectHandler redirectHandler = new MockRedirectHandler(); - TokenPoller poller = MockTokenPoller.onPoll((tokenUri) -> { + TokenPoller poller = MockTokenPoller.onPoll(tokenUri -> { sleepUninterruptibly(Duration.ofMillis(20)); return TokenPollResult.pending(TOKEN_URI); }); diff --git a/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeAssignmentStats.java b/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeAssignmentStats.java index 746c6e86beb3..02330f922aa9 100644 --- a/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeAssignmentStats.java +++ b/core/trino-main/src/main/java/io/trino/execution/scheduler/NodeAssignmentStats.java @@ -47,7 +47,7 @@ public NodeAssignmentStats(NodeTaskMap nodeTaskMap, NodeMap nodeMap, List createEmptySplitInfo = (ignored) -> new PendingSplitInfo(PartitionedSplitsInfo.forZeroSplits(), 0); + Function createEmptySplitInfo = ignored -> new PendingSplitInfo(PartitionedSplitsInfo.forZeroSplits(), 0); for (InternalNode node : nodeMap.getNodesByHostAndPort().values()) { stageQueuedSplitInfo.computeIfAbsent(node.getNodeIdentifier(), createEmptySplitInfo); } diff --git a/core/trino-main/src/main/java/io/trino/metadata/FunctionResolver.java b/core/trino-main/src/main/java/io/trino/metadata/FunctionResolver.java index 48913ce8b2fa..9b99c6d04ec0 100644 --- a/core/trino-main/src/main/java/io/trino/metadata/FunctionResolver.java +++ b/core/trino-main/src/main/java/io/trino/metadata/FunctionResolver.java @@ -281,7 +281,7 @@ private static boolean someParameterIsUnknown(List parameters) private List getUnknownOnlyCastFunctions(List applicableFunction, List actualParameters) { return applicableFunction.stream() - .filter((function) -> onlyCastsUnknown(function, actualParameters)) + .filter(function -> onlyCastsUnknown(function, actualParameters)) .collect(toImmutableList()); } diff --git a/core/trino-main/src/main/java/io/trino/operator/DeduplicatingDirectExchangeBuffer.java b/core/trino-main/src/main/java/io/trino/operator/DeduplicatingDirectExchangeBuffer.java index a4cc8f48917d..e60aee08cba8 100644 --- a/core/trino-main/src/main/java/io/trino/operator/DeduplicatingDirectExchangeBuffer.java +++ b/core/trino-main/src/main/java/io/trino/operator/DeduplicatingDirectExchangeBuffer.java @@ -626,7 +626,7 @@ public synchronized OutputSource createOutputSource(Set selectedTasks) // Finish ExchangeSink and create ExchangeSource asynchronously to avoid blocking an ExchangeClient thread for potentially substantial amount of time ListenableFuture exchangeSourceFuture = FluentFuture.from(toListenableFuture(exchangeSink.finish())) - .transformAsync((ignored) -> { + .transformAsync(ignored -> { exchange.sinkFinished(sinkInstanceHandle); synchronized (this) { exchangeSink = null; diff --git a/core/trino-main/src/main/java/io/trino/operator/exchange/PageReference.java b/core/trino-main/src/main/java/io/trino/operator/exchange/PageReference.java index aa77f2ed2916..8748af0cab70 100644 --- a/core/trino-main/src/main/java/io/trino/operator/exchange/PageReference.java +++ b/core/trino-main/src/main/java/io/trino/operator/exchange/PageReference.java @@ -75,7 +75,7 @@ interface PageReleasedListener static PageReleasedListener forLocalExchangeMemoryManager(LocalExchangeMemoryManager memoryManager) { requireNonNull(memoryManager, "memoryManager is null"); - return (releasedSizeInBytes) -> memoryManager.updateMemoryUsage(-releasedSizeInBytes); + return releasedSizeInBytes -> memoryManager.updateMemoryUsage(-releasedSizeInBytes); } } } diff --git a/core/trino-main/src/main/java/io/trino/operator/exchange/PassthroughExchanger.java b/core/trino-main/src/main/java/io/trino/operator/exchange/PassthroughExchanger.java index 85f3a7c46eda..cbf15e688880 100644 --- a/core/trino-main/src/main/java/io/trino/operator/exchange/PassthroughExchanger.java +++ b/core/trino-main/src/main/java/io/trino/operator/exchange/PassthroughExchanger.java @@ -34,7 +34,7 @@ public PassthroughExchanger(LocalExchangeSource localExchangeSource, long buffer this.localExchangeSource = requireNonNull(localExchangeSource, "localExchangeSource is null"); this.memoryTracker = requireNonNull(memoryTracker, "memoryTracker is null"); bufferMemoryManager = new LocalExchangeMemoryManager(bufferMaxMemory); - onPageReleased = (releasedSizeInBytes) -> { + onPageReleased = releasedSizeInBytes -> { this.bufferMemoryManager.updateMemoryUsage(-releasedSizeInBytes); this.memoryTracker.accept(-releasedSizeInBytes); }; diff --git a/core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java b/core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java index 2074fbfda499..6e240140c4f4 100644 --- a/core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java +++ b/core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java @@ -547,7 +547,7 @@ public Type process(Node node, @Nullable StackableAstVisitorContext con protected Type visitRow(Row node, StackableAstVisitorContext context) { List types = node.getItems().stream() - .map((child) -> process(child, context)) + .map(child -> process(child, context)) .collect(toImmutableList()); Type type = RowType.anonymous(types); diff --git a/core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java b/core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java index 7d43aa7142fb..8787ef340816 100644 --- a/core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java +++ b/core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java @@ -763,7 +763,7 @@ private Optional coerceComparisonWithRounding( Type valueType = nullableValue.getType(); Object value = nullableValue.getValue(); return floorValue(valueType, symbolExpressionType, value) - .map((floorValue) -> rewriteComparisonExpression(symbolExpressionType, symbolExpression, valueType, value, floorValue, comparisonOperator)); + .map(floorValue -> rewriteComparisonExpression(symbolExpressionType, symbolExpression, valueType, value, floorValue, comparisonOperator)); } private Expression rewriteComparisonExpression( @@ -833,7 +833,7 @@ private Expression rewriteComparisonExpression( private Optional floorValue(Type fromType, Type toType, Object value) { return getSaturatedFloorCastOperator(fromType, toType) - .map((operator) -> functionInvoker.invoke(operator, session.toConnectorSession(), value)); + .map(operator -> functionInvoker.invoke(operator, session.toConnectorSession(), value)); } private Optional getSaturatedFloorCastOperator(Type fromType, Type toType) diff --git a/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/CanonicalizeExpressionRewriter.java b/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/CanonicalizeExpressionRewriter.java index 74ddb648aa40..f9ba4d44172c 100644 --- a/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/CanonicalizeExpressionRewriter.java +++ b/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/CanonicalizeExpressionRewriter.java @@ -140,7 +140,7 @@ public Expression rewriteIfExpression(IfExpression node, Void context, Expressio Expression condition = treeRewriter.rewrite(node.getCondition(), context); Expression trueValue = treeRewriter.rewrite(node.getTrueValue(), context); - Optional falseValue = node.getFalseValue().map((value) -> treeRewriter.rewrite(value, context)); + Optional falseValue = node.getFalseValue().map(value -> treeRewriter.rewrite(value, context)); return new SearchedCaseExpression(ImmutableList.of(new WhenClause(condition, trueValue)), falseValue); } diff --git a/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/ReorderJoins.java b/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/ReorderJoins.java index 741e13ff3bad..3e67a5fe6602 100644 --- a/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/ReorderJoins.java +++ b/core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/ReorderJoins.java @@ -228,7 +228,7 @@ private JoinEnumerationResult chooseJoinOrder(LinkedHashSet sources, L memo.put(multiJoinKey, bestResult); } - bestResult.planNode.ifPresent((planNode) -> log.debug("Least cost join was: %s", planNode)); + bestResult.planNode.ifPresent(planNode -> log.debug("Least cost join was: %s", planNode)); return bestResult; } @@ -446,7 +446,7 @@ private List getPossibleJoinNodes(JoinNode joinNode, Join private List getPossibleJoinNodes(JoinNode joinNode, DistributionType distributionType) { - return getPossibleJoinNodes(joinNode, distributionType, (node) -> true); + return getPossibleJoinNodes(joinNode, distributionType, node -> true); } private List getPossibleJoinNodes(JoinNode joinNode, DistributionType distributionType, Predicate isAllowed) diff --git a/core/trino-main/src/main/java/io/trino/sql/relational/SqlToRowExpressionTranslator.java b/core/trino-main/src/main/java/io/trino/sql/relational/SqlToRowExpressionTranslator.java index b58d4361522c..de82e32e90f0 100644 --- a/core/trino-main/src/main/java/io/trino/sql/relational/SqlToRowExpressionTranslator.java +++ b/core/trino-main/src/main/java/io/trino/sql/relational/SqlToRowExpressionTranslator.java @@ -577,7 +577,7 @@ protected RowExpression visitSearchedCaseExpression(SearchedCaseExpression node, */ RowExpression expression = node.getDefaultValue() - .map((value) -> process(value, context)) + .map(value -> process(value, context)) .orElse(constantNull(getType(node))); for (WhenClause clause : Lists.reverse(node.getWhenClauses())) { diff --git a/core/trino-main/src/main/java/io/trino/type/DecimalCasts.java b/core/trino-main/src/main/java/io/trino/type/DecimalCasts.java index 0ecb1f87e683..c66d7f855a93 100644 --- a/core/trino-main/src/main/java/io/trino/type/DecimalCasts.java +++ b/core/trino-main/src/main/java/io/trino/type/DecimalCasts.java @@ -105,7 +105,7 @@ private static SqlScalarFunction castFunctionFromDecimalTo(TypeSignature to, Str .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods(methodNames) - .withExtraParameters((context) -> { + .withExtraParameters(context -> { long precision = context.getLiteral("precision"); long scale = context.getLiteral("scale"); Object tenToScale; @@ -140,7 +140,7 @@ private static SqlScalarFunction castFunctionToDecimalFromBuilder(TypeSignature .returnConvention(nullableResult ? NULLABLE_RETURN : FAIL_ON_NULL) .implementation(methodsGroup -> methodsGroup .methods(methodNames) - .withExtraParameters((context) -> { + .withExtraParameters(context -> { DecimalType resultType = (DecimalType) context.getReturnType(); Object tenToScale; if (isShortDecimal(resultType)) { @@ -163,7 +163,7 @@ private static SqlScalarFunction castFunctionToDecimalFromBuilder(TypeSignature .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods("shortDecimalToVarchar", "longDecimalToVarchar") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { long scale = context.getLiteral("scale"); VarcharType resultType = (VarcharType) context.getReturnType(); long length; diff --git a/core/trino-main/src/main/java/io/trino/type/DecimalSaturatedFloorCasts.java b/core/trino-main/src/main/java/io/trino/type/DecimalSaturatedFloorCasts.java index f380ea9e046b..cd3118e71ea6 100644 --- a/core/trino-main/src/main/java/io/trino/type/DecimalSaturatedFloorCasts.java +++ b/core/trino-main/src/main/java/io/trino/type/DecimalSaturatedFloorCasts.java @@ -49,7 +49,7 @@ private DecimalSaturatedFloorCasts() {} .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods("shortDecimalToShortDecimal", "shortDecimalToLongDecimal", "longDecimalToShortDecimal", "longDecimalToLongDecimal") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { int sourcePrecision = toIntExact(context.getLiteral("source_precision")); int sourceScale = toIntExact(context.getLiteral("source_scale")); int resultPrecision = toIntExact(context.getLiteral("result_precision")); @@ -120,7 +120,7 @@ private static SqlScalarFunction decimalToGenericIntegerTypeSaturatedFloorCast(T .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods("shortDecimalToGenericIntegerType", "longDecimalToGenericIntegerType") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { int sourceScale = toIntExact(context.getLiteral("source_scale")); return ImmutableList.of(sourceScale, minValue, maxValue); }))) @@ -171,7 +171,7 @@ private static SqlScalarFunction genericIntegerTypeToDecimalSaturatedFloorCast(T .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods("genericIntegerTypeToShortDecimal", "genericIntegerTypeToLongDecimal") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { int resultPrecision = toIntExact(context.getLiteral("result_precision")); int resultScale = toIntExact(context.getLiteral("result_scale")); return ImmutableList.of(resultPrecision, resultScale); diff --git a/core/trino-main/src/main/java/io/trino/type/DecimalToDecimalCasts.java b/core/trino-main/src/main/java/io/trino/type/DecimalToDecimalCasts.java index bf554dd7d7c5..31ccda0a99cd 100644 --- a/core/trino-main/src/main/java/io/trino/type/DecimalToDecimalCasts.java +++ b/core/trino-main/src/main/java/io/trino/type/DecimalToDecimalCasts.java @@ -40,7 +40,7 @@ public final class DecimalToDecimalCasts .choice(choice -> choice .implementation(methodsGroup -> methodsGroup .methods("shortToShortCast") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { DecimalType argumentType = (DecimalType) context.getParameterTypes().get(0); DecimalType resultType = (DecimalType) context.getReturnType(); long rescale = longTenToNth(Math.abs(resultType.getScale() - argumentType.getScale())); @@ -51,7 +51,7 @@ public final class DecimalToDecimalCasts })) .implementation(methodsGroup -> methodsGroup .methods("shortToLongCast", "longToShortCast", "longToLongCast") - .withExtraParameters((context) -> { + .withExtraParameters(context -> { DecimalType argumentType = (DecimalType) context.getParameterTypes().get(0); DecimalType resultType = (DecimalType) context.getReturnType(); return ImmutableList.of( diff --git a/core/trino-main/src/test/java/io/trino/connector/MockConnectorFactory.java b/core/trino-main/src/test/java/io/trino/connector/MockConnectorFactory.java index fadc541689b0..757b2c6b8259 100644 --- a/core/trino-main/src/test/java/io/trino/connector/MockConnectorFactory.java +++ b/core/trino-main/src/test/java/io/trino/connector/MockConnectorFactory.java @@ -328,7 +328,7 @@ public static final class Builder private ListRoleGrants roleGrants = defaultRoleAuthorizations(); private Grants schemaGrants = new AllowAllGrants<>(); private Grants tableGrants = new AllowAllGrants<>(); - private Function rowFilter = (tableName) -> null; + private Function rowFilter = tableName -> null; private BiFunction columnMask = (tableName, columnName) -> null; private boolean allowMissingColumnsOnInsert; @@ -603,7 +603,7 @@ public MockConnectorFactory build() public static Function> defaultListSchemaNames() { - return (session) -> ImmutableList.of(); + return session -> ImmutableList.of(); } public static ListRoleGrants defaultRoleAuthorizations() diff --git a/core/trino-main/src/test/java/io/trino/execution/scheduler/TestStageTaskSourceFactory.java b/core/trino-main/src/test/java/io/trino/execution/scheduler/TestStageTaskSourceFactory.java index a01d4f441692..84cb0e72f7f5 100644 --- a/core/trino-main/src/test/java/io/trino/execution/scheduler/TestStageTaskSourceFactory.java +++ b/core/trino-main/src/test/java/io/trino/execution/scheduler/TestStageTaskSourceFactory.java @@ -408,7 +408,7 @@ private static HashDistributionTaskSource createHashDistributionTaskSource( partitionedExchangeSources, replicatedExchangeSources, splitBatchSize, - (getSplitsTime) -> {}, + getSplitsTime -> {}, bucketToPartitionMap, bucketNodeMap, Optional.of(CATALOG)); @@ -625,7 +625,7 @@ private static SourceDistributionTaskSource createSourceDistributionTaskSource( new TestingSplitSource(CATALOG, splits), replicatedSources, splitBatchSize, - (getSplitsTime) -> {}, + getSplitsTime -> {}, Optional.of(CATALOG), minSplitsPerTask, splitWeightPerTask, @@ -676,7 +676,7 @@ private static Optional> addressesList(String... addresses) private static BucketNodeMap getTestingBucketNodeMap(int bucketCount) { - return new DynamicBucketNodeMap((split) -> { + return new DynamicBucketNodeMap(split -> { TestingConnectorSplit testingConnectorSplit = (TestingConnectorSplit) split.getConnectorSplit(); return testingConnectorSplit.getBucket().getAsInt(); }, bucketCount); diff --git a/core/trino-main/src/test/java/io/trino/metadata/TestFunctionRegistry.java b/core/trino-main/src/test/java/io/trino/metadata/TestFunctionRegistry.java index 14c82ddd4462..70e577eaa4b2 100644 --- a/core/trino-main/src/test/java/io/trino/metadata/TestFunctionRegistry.java +++ b/core/trino-main/src/test/java/io/trino/metadata/TestFunctionRegistry.java @@ -286,7 +286,7 @@ private static SignatureBuilder functionSignature(List arguments, String { ImmutableSet literalParameters = ImmutableSet.of("p", "s", "p1", "s1", "p2", "s2", "p3", "s3"); List argumentSignatures = arguments.stream() - .map((signature) -> parseTypeSignature(signature, literalParameters)) + .map(signature -> parseTypeSignature(signature, literalParameters)) .collect(toImmutableList()); return new SignatureBuilder() .returnType(parseTypeSignature(returnType, literalParameters)) diff --git a/core/trino-main/src/test/java/io/trino/operator/TestHttpPageBufferClient.java b/core/trino-main/src/test/java/io/trino/operator/TestHttpPageBufferClient.java index fc732a1871e6..cbc2718724fb 100644 --- a/core/trino-main/src/test/java/io/trino/operator/TestHttpPageBufferClient.java +++ b/core/trino-main/src/test/java/io/trino/operator/TestHttpPageBufferClient.java @@ -366,7 +366,7 @@ public void testExceptionFromResponseHandler() TestingTicker ticker = new TestingTicker(); AtomicReference tickerIncrement = new AtomicReference<>(new Duration(0, TimeUnit.SECONDS)); - TestingHttpClient.Processor processor = (input) -> { + TestingHttpClient.Processor processor = input -> { Duration delta = tickerIncrement.get(); ticker.increment(delta.toMillis(), TimeUnit.MILLISECONDS); throw new RuntimeException("Foo"); diff --git a/core/trino-main/src/test/java/io/trino/server/TestDynamicFilterService.java b/core/trino-main/src/test/java/io/trino/server/TestDynamicFilterService.java index b8770e931010..4768ab353407 100644 --- a/core/trino-main/src/test/java/io/trino/server/TestDynamicFilterService.java +++ b/core/trino-main/src/test/java/io/trino/server/TestDynamicFilterService.java @@ -664,7 +664,7 @@ public void testDynamicFilterConsumer() queryId, 0, dynamicFilters, - (domains) -> domains.forEach((filter, domain) -> assertNull(consumerCollectedFilters.put(filter, domain)))); + domains -> domains.forEach((filter, domain) -> assertNull(consumerCollectedFilters.put(filter, domain)))); assertTrue(consumerCollectedFilters.isEmpty()); dynamicFilterService.addTaskDynamicFilters( @@ -686,7 +686,7 @@ filterId1, singleValue(INTEGER, 3L), queryId, 0, ImmutableSet.of(filterId1), - (domains) -> domains.forEach((filter, domain) -> assertNull(secondConsumerCollectedFilters.put(filter, domain)))); + domains -> domains.forEach((filter, domain) -> assertNull(secondConsumerCollectedFilters.put(filter, domain)))); assertEquals(secondConsumerCollectedFilters, ImmutableMap.of(filterId1, multipleValues(INTEGER, ImmutableList.of(1L, 3L)))); // complete filterId2 @@ -722,7 +722,7 @@ public void testDynamicFilterConsumerCallbackCount() queryId, 0, dynamicFilters, - (domains) -> { + domains -> { callbackCount.getAndIncrement(); domains.forEach((filter, domain) -> assertNull(consumerCollectedFilters.put(filter, domain))); }); @@ -756,7 +756,7 @@ filterId1, multipleValues(INTEGER, ImmutableList.of(1L, 3L)), queryId, 0, dynamicFilters, - (domains) -> { + domains -> { secondCallbackCount.getAndIncrement(); domains.forEach((filter, domain) -> assertNull(secondConsumerCollectedFilters.put(filter, domain))); }); diff --git a/core/trino-main/src/test/java/io/trino/server/security/TestHeaderAuthenticatorManager.java b/core/trino-main/src/test/java/io/trino/server/security/TestHeaderAuthenticatorManager.java index ca5dc6b6b4e6..e36d5a08dff8 100644 --- a/core/trino-main/src/test/java/io/trino/server/security/TestHeaderAuthenticatorManager.java +++ b/core/trino-main/src/test/java/io/trino/server/security/TestHeaderAuthenticatorManager.java @@ -97,7 +97,7 @@ public String getName() @Override public HeaderAuthenticator create(Map config) { - return (headers) -> Optional.ofNullable(headers.getHeader(header)) + return headers -> Optional.ofNullable(headers.getHeader(header)) .map(values -> new BasicPrincipal(values.get(0))) .orElseThrow(() -> new AccessDeniedException("You shall not pass!")); } diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestPruneCountAggregationOverScalar.java b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestPruneCountAggregationOverScalar.java index a53d5e997f7b..d2d89580c25e 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestPruneCountAggregationOverScalar.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestPruneCountAggregationOverScalar.java @@ -75,7 +75,7 @@ public void testFiresOnNestedCountAggregate() .globalGrouping() .step(AggregationNode.Step.SINGLE) .source( - p.aggregation((aggregationBuilder) -> aggregationBuilder + p.aggregation(aggregationBuilder -> aggregationBuilder .source(p.tableScan(ImmutableList.of(), ImmutableMap.of())) .globalGrouping() .step(AggregationNode.Step.SINGLE))))) diff --git a/core/trino-parser/src/main/java/io/trino/sql/ExpressionFormatter.java b/core/trino-parser/src/main/java/io/trino/sql/ExpressionFormatter.java index b46b73d3d102..d7c90fdaed2f 100644 --- a/core/trino-parser/src/main/java/io/trino/sql/ExpressionFormatter.java +++ b/core/trino-parser/src/main/java/io/trino/sql/ExpressionFormatter.java @@ -148,7 +148,7 @@ protected String visitNode(Node node, Void context) protected String visitRow(Row node, Void context) { return "ROW (" + Joiner.on(", ").join(node.getItems().stream() - .map((child) -> process(child, context)) + .map(child -> process(child, context)) .collect(toList())) + ")"; } @@ -613,7 +613,7 @@ protected String visitSearchedCaseExpression(SearchedCaseExpression node, Void c } node.getDefaultValue() - .ifPresent((value) -> parts.add("ELSE").add(process(value, context))); + .ifPresent(value -> parts.add("ELSE").add(process(value, context))); parts.add("END"); @@ -633,7 +633,7 @@ protected String visitSimpleCaseExpression(SimpleCaseExpression node, Void conte } node.getDefaultValue() - .ifPresent((value) -> parts.add("ELSE").add(process(value, context))); + .ifPresent(value -> parts.add("ELSE").add(process(value, context))); parts.add("END"); diff --git a/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java b/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java index 806cc2b8d486..9739346d85ea 100644 --- a/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java +++ b/core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java @@ -1048,11 +1048,11 @@ protected Void visitShowFunctions(ShowFunctions node, Integer indent) { builder.append("SHOW FUNCTIONS"); - node.getLikePattern().ifPresent((value) -> builder + node.getLikePattern().ifPresent(value -> builder .append(" LIKE ") .append(formatStringLiteral(value))); - node.getEscape().ifPresent((value) -> builder + node.getEscape().ifPresent(value -> builder .append(" ESCAPE ") .append(formatStringLiteral(value))); diff --git a/lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java b/lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java index 290047108827..bfc2c24c7127 100644 --- a/lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java +++ b/lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java @@ -622,20 +622,20 @@ private Function getConverter(PrimitiveType primitiveType) { switch (primitiveType.getPrimitiveTypeName()) { case BOOLEAN: - return (buffer) -> buffer.get(0) != 0; + return buffer -> buffer.get(0) != 0; case INT32: - return (buffer) -> buffer.order(LITTLE_ENDIAN).getInt(0); + return buffer -> buffer.order(LITTLE_ENDIAN).getInt(0); case INT64: - return (buffer) -> buffer.order(LITTLE_ENDIAN).getLong(0); + return buffer -> buffer.order(LITTLE_ENDIAN).getLong(0); case FLOAT: - return (buffer) -> buffer.order(LITTLE_ENDIAN).getFloat(0); + return buffer -> buffer.order(LITTLE_ENDIAN).getFloat(0); case DOUBLE: - return (buffer) -> buffer.order(LITTLE_ENDIAN).getDouble(0); + return buffer -> buffer.order(LITTLE_ENDIAN).getDouble(0); case FIXED_LEN_BYTE_ARRAY: case BINARY: case INT96: default: - return (buffer) -> Binary.fromReusedByteBuffer(buffer); + return buffer -> Binary.fromReusedByteBuffer(buffer); } } } diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java index 31a1da4551ae..1bb6a337f349 100644 --- a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java +++ b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java @@ -2545,7 +2545,7 @@ public ConnectorTableProperties getTableProperties(ConnectorSession session, Con // Do not create tuple domains for every partition at the same time! // There can be a huge number of partitions so use an iterable so // all domains do not need to be in memory at the same time. - Iterable> partitionDomains = Iterables.transform(partitions, (hivePartition) -> TupleDomain.fromFixedValues(hivePartition.getKeys())); + Iterable> partitionDomains = Iterables.transform(partitions, hivePartition -> TupleDomain.fromFixedValues(hivePartition.getKeys())); discretePredicates = Optional.of(new DiscretePredicates(partitionColumns, partitionDomains)); } diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitWeightProvider.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitWeightProvider.java index 03f6fa418d84..09357ef6b656 100644 --- a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitWeightProvider.java +++ b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitWeightProvider.java @@ -21,6 +21,6 @@ public interface HiveSplitWeightProvider static HiveSplitWeightProvider uniformStandardWeightProvider() { - return (splitSizeInBytes) -> SplitWeight.standard(); + return splitSizeInBytes -> SplitWeight.standard(); } } diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/HiveSecurityModule.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/HiveSecurityModule.java index 8766c3317496..5a5a3f51b138 100644 --- a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/HiveSecurityModule.java +++ b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/HiveSecurityModule.java @@ -71,7 +71,7 @@ private static class StaticAccessControlMetadataModule @Override public void configure(Binder binder) { - binder.bind(AccessControlMetadataFactory.class).toInstance((metastore) -> new AccessControlMetadata() {}); + binder.bind(AccessControlMetadataFactory.class).toInstance(metastore -> new AccessControlMetadata() {}); } } } diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java index 1bbae553875f..e833bb80a939 100644 --- a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java +++ b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java @@ -845,7 +845,7 @@ protected final void setup(String databaseName, HiveConfig hiveConfig, HiveMetas ImmutableSet.of( new PartitionsSystemTableProvider(partitionManager, TESTING_TYPE_MANAGER), new PropertiesSystemTableProvider()), - (metastore) -> new NoneHiveMaterializedViewMetadata() + metastore -> new NoneHiveMaterializedViewMetadata() { @Override public Optional getMaterializedView(ConnectorSession session, SchemaTableName viewName) diff --git a/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotQueryClient.java b/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotQueryClient.java index 8a13aa57bc9c..d4fc30e170c1 100644 --- a/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotQueryClient.java +++ b/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotQueryClient.java @@ -101,7 +101,7 @@ public Map queryPinotServerForDataTable(String query, BrokerRequest offlineBrokerRequest = TableNameBuilder.isOfflineTableResource(tableName) ? brokerRequest : null; BrokerRequest realtimeBrokerRequest = TableNameBuilder.isRealtimeTableResource(tableName) ? brokerRequest : null; AsyncQueryResponse asyncQueryResponse = - doWithRetries(pinotRetryCount, (requestId) -> queryRouter.submitQuery(requestId, rawTableName, offlineBrokerRequest, offlineRoutingTable, realtimeBrokerRequest, realtimeRoutingTable, connectionTimeoutInMillis)); + doWithRetries(pinotRetryCount, requestId -> queryRouter.submitQuery(requestId, rawTableName, offlineBrokerRequest, offlineRoutingTable, realtimeBrokerRequest, realtimeRoutingTable, connectionTimeoutInMillis)); try { Map response = asyncQueryResponse.getResponse(); Map dataTableMap = new HashMap<>(); diff --git a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotClient.java b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotClient.java index e5d9e1f5d8b0..90a3186aaa2d 100755 --- a/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotClient.java +++ b/plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotClient.java @@ -35,7 +35,7 @@ public class TestPinotClient @Test public void testBrokersParsed() { - HttpClient httpClient = new TestingHttpClient((request) -> TestingResponse.mockResponse(HttpStatus.OK, MediaType.JSON_UTF_8, "{\n" + + HttpClient httpClient = new TestingHttpClient(request -> TestingResponse.mockResponse(HttpStatus.OK, MediaType.JSON_UTF_8, "{\n" + " \"tableName\": \"dummy\",\n" + " \"brokers\": [\n" + " {\n" + diff --git a/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/metadata/DatabaseShardManager.java b/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/metadata/DatabaseShardManager.java index e1dc1e7655fc..6d28312bbafd 100644 --- a/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/metadata/DatabaseShardManager.java +++ b/plugin/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/metadata/DatabaseShardManager.java @@ -294,7 +294,7 @@ public void commitShards(long transactionId, long tableId, List colu Map nodeIds = toNodeIdMap(shards); - runCommit(transactionId, (handle) -> { + runCommit(transactionId, handle -> { externalBatchId.ifPresent(shardDaoSupplier.attach(handle)::insertExternalBatch); lockTable(handle, tableId); insertShardsAndIndex(tableId, columns, shards, nodeIds, handle); @@ -311,7 +311,7 @@ public void replaceShardUuids(long transactionId, long tableId, List { Map nodeIds = toNodeIdMap(newShards); - runCommit(transactionId, (handle) -> { + runCommit(transactionId, handle -> { lockTable(handle, tableId); if (updateTime.isEmpty() && handle.attach(MetadataDao.class).isMaintenanceBlockedLocked(tableId)) { diff --git a/plugin/trino-tpch/src/test/java/io/trino/plugin/tpch/statistics/TableStatisticsRecorder.java b/plugin/trino-tpch/src/test/java/io/trino/plugin/tpch/statistics/TableStatisticsRecorder.java index d98f77c5275b..f54d66470ada 100644 --- a/plugin/trino-tpch/src/test/java/io/trino/plugin/tpch/statistics/TableStatisticsRecorder.java +++ b/plugin/trino-tpch/src/test/java/io/trino/plugin/tpch/statistics/TableStatisticsRecorder.java @@ -59,7 +59,7 @@ private TableStatisticsData recordStatistics(Iterable private Map, ColumnStatisticsRecorder> createStatisticsRecorders(List> columns) { return columns.stream() - .collect(toImmutableMap(identity(), (column) -> new ColumnStatisticsRecorder(column.getType()))); + .collect(toImmutableMap(identity(), column -> new ColumnStatisticsRecorder(column.getType()))); } private Comparable getTpchValue(E row, TpchColumn column) diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestTls.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestTls.java index c6be2200903e..f1e2be95d3d7 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestTls.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/TestTls.java @@ -59,7 +59,7 @@ public void testHttpPortIsClosed() assertThat(activeNodesUrls).hasSize(3); List hosts = activeNodesUrls.stream() - .map((uri) -> URI.create(uri).getHost()) + .map(uri -> URI.create(uri).getHost()) .collect(toList()); for (String host : hosts) { @@ -87,7 +87,7 @@ private List getActiveNodesUrls() .executeQuery("SELECT http_uri FROM system.runtime.nodes"); return queryResult.rows() .stream() - .map((row) -> row.get(0).toString()) + .map(row -> row.get(0).toString()) .collect(toList()); } diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestCsv.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestCsv.java index eb5f0b8530bf..295ee24ed294 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestCsv.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestCsv.java @@ -166,7 +166,7 @@ private static void assertSelect(String query, String tableName) { QueryResult expected = onTrino().executeQuery(format(query, "tpch.tiny.nation")); List expectedRows = expected.rows().stream() - .map((columns) -> row(columns.toArray())) + .map(columns -> row(columns.toArray())) .collect(toImmutableList()); QueryResult actual = onTrino().executeQuery(format(query, tableName)); assertThat(actual) diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java index 6a17cda895ef..33a03d020aa4 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java @@ -949,7 +949,7 @@ private static void assertResultEqualForLineitemTable(String query, String table { QueryResult expected = onTrino().executeQuery(format(query, "tpch." + TPCH_SCHEMA + ".lineitem")); List expectedRows = expected.rows().stream() - .map((columns) -> row(columns.toArray())) + .map(columns -> row(columns.toArray())) .collect(toImmutableList()); QueryResult actual = onTrino().executeQuery(format(query, tableName)); assertThat(actual) diff --git a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestJoinQueries.java b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestJoinQueries.java index 82485ee44237..4c0c8b8e47d3 100644 --- a/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestJoinQueries.java +++ b/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestJoinQueries.java @@ -893,7 +893,7 @@ public void testOuterJoinWithComplexCorrelatedSubquery() condition); queryTemplate.replaceAll( - (query) -> assertQueryFails(query, "line .*: Reference to column 'x' from outer scope not allowed in this context"), + query -> assertQueryFails(query, "line .*: Reference to column 'x' from outer scope not allowed in this context"), ImmutableList.of(type.of("left"), type.of("right"), type.of("full")), ImmutableList.of( condition.of("EXISTS(SELECT 1 WHERE x = y)"), diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java index 3104a73fb4d0..ba2ea0a7aad2 100644 --- a/testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java +++ b/testing/trino-testing/src/main/java/io/trino/testing/BaseFailureRecoveryTest.java @@ -748,17 +748,17 @@ public Optional getUpdatedTableStatistics() protected static Function rootStage() { - return (result) -> parseInt(getRootStage(result).getStageId()); + return result -> parseInt(getRootStage(result).getStageId()); } protected static Function boundaryCoordinatorStage() { - return (result) -> findStageId(result, stage -> stage.isCoordinatorOnly() && stage.getSubStages().stream().noneMatch(StageStats::isCoordinatorOnly)); + return result -> findStageId(result, stage -> stage.isCoordinatorOnly() && stage.getSubStages().stream().noneMatch(StageStats::isCoordinatorOnly)); } protected static Function boundaryDistributedStage() { - return (result) -> { + return result -> { StageStats rootStage = getRootStage(result); if (!rootStage.isCoordinatorOnly()) { return parseInt(rootStage.getStageId()); @@ -772,12 +772,12 @@ protected static Function boundaryDistributedStage( protected static Function intermediateDistributedStage() { - return (result) -> findStageId(result, stage -> !stage.isCoordinatorOnly() && !stage.getSubStages().isEmpty()); + return result -> findStageId(result, stage -> !stage.isCoordinatorOnly() && !stage.getSubStages().isEmpty()); } protected static Function leafStage() { - return (result) -> findStageId(result, stage -> stage.getSubStages().isEmpty()); + return result -> findStageId(result, stage -> stage.getSubStages().isEmpty()); } private static int findStageId(MaterializedResult result, Predicate predicate)