From 8c70bd44058957cadd379d7f80b09510cbffea62 Mon Sep 17 00:00:00 2001 From: Ashhar Hasan Date: Thu, 3 Feb 2022 11:12:19 +0530 Subject: [PATCH] Increase timeout when testing Docker image The ARM64 Docker image runs under emulation and hence can take time to start up. The existing timeout of ~150 seconds is too close to the amount of time it takes for the image to start and hence introduces occasional flakiness. We also make available the container's logs in timeouts to help debug if needed. --- core/docker/container-test.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/docker/container-test.sh b/core/docker/container-test.sh index d8b1e01b8b0e..33206b47a7cb 100644 --- a/core/docker/container-test.sh +++ b/core/docker/container-test.sh @@ -5,7 +5,7 @@ function cleanup { } function test_trino_starts { - local QUERY_PERIOD=5 + local QUERY_PERIOD=10 local QUERY_RETRIES=30 CONTAINER_ID= @@ -21,6 +21,8 @@ function test_trino_starts { do if [[ $((I++)) -ge ${QUERY_RETRIES} ]]; then echo "🚨 Too many retries waiting for Trino to start" + echo "Logs from ${CONTAINER_ID} follow..." + docker logs "${CONTAINER_ID}" break fi sleep ${QUERY_PERIOD}