From c4bd7ed8f380ebc68cf262860502b8f576a9a649 Mon Sep 17 00:00:00 2001 From: Lukasz Stec Date: Tue, 1 Feb 2022 16:24:31 +0100 Subject: [PATCH] Fix BenchmarkGroupByHash.createVarcharPages values ByteBuffer.flip was missing, which cased the benchmark to test only one empty value. --- .../src/test/java/io/trino/operator/BenchmarkGroupByHash.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java b/core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java index 0555de661f89..b020f26417d8 100644 --- a/core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java +++ b/core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java @@ -290,7 +290,7 @@ private static List createVarcharPages(int positionCount, int groupCount, PageBuilder pageBuilder = new PageBuilder(types); for (int position = 0; position < positionCount; position++) { int rand = ThreadLocalRandom.current().nextInt(groupCount); - Slice value = Slices.wrappedBuffer(ByteBuffer.allocate(4).putInt(rand)); + Slice value = Slices.wrappedBuffer(ByteBuffer.allocate(4).putInt(rand).flip()); pageBuilder.declarePosition(); for (int channel = 0; channel < channelCount; channel++) { VARCHAR.writeSlice(pageBuilder.getBlockBuilder(channel), value);