From 0d9415e105826f6944c00986de770c134d83d3d7 Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Tue, 1 Feb 2022 10:00:31 +0100 Subject: [PATCH] Document various Iceberg compatibility tests --- .../product/iceberg/TestIcebergHiveTablesCompatibility.java | 6 ++++++ .../product/iceberg/TestIcebergHiveViewsCompatibility.java | 5 +++++ .../tests/product/iceberg/TestIcebergRedirectionToHive.java | 6 ++++++ .../product/iceberg/TestIcebergSparkCompatibility.java | 3 +++ 4 files changed, 20 insertions(+) diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveTablesCompatibility.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveTablesCompatibility.java index a30250879ab7..e7a99b3361ae 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveTablesCompatibility.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveTablesCompatibility.java @@ -24,6 +24,12 @@ import static io.trino.tests.product.utils.QueryExecutors.onTrino; import static java.lang.String.format; +/** + * Tests interactions between Iceberg and Hive connectors, when one tries to read a table created by the other. + * + * @see TestIcebergRedirectionToHive + * @see TestIcebergHiveViewsCompatibility + */ public class TestIcebergHiveTablesCompatibility extends ProductTest { diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java index 1086060f4845..e521c0814528 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java @@ -30,6 +30,11 @@ import static java.util.stream.Collectors.toList; import static org.assertj.core.api.Assertions.assertThatThrownBy; +/** + * Tests interactions between Iceberg and Hive connectors, when one tries to read a view created by the other. + * + * @see TestIcebergHiveTablesCompatibility + */ public class TestIcebergHiveViewsCompatibility extends ProductTest { diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRedirectionToHive.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRedirectionToHive.java index 4b20a28c5472..f11e21ca9620 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRedirectionToHive.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRedirectionToHive.java @@ -35,6 +35,12 @@ import static java.lang.String.format; import static java.sql.JDBCType.VARCHAR; +/** + * Tests interactions between Iceberg and Hive connectors, when one tries to read a table created by the other + * with redirects enabled. + * + * @see TestIcebergHiveTablesCompatibility + */ public class TestIcebergRedirectionToHive extends ProductTest { diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java index 37c87746c5e9..544a0c2d6e2e 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java @@ -60,6 +60,9 @@ import static java.util.concurrent.TimeUnit.SECONDS; import static org.testng.Assert.assertTrue; +/** + * Tests compatibility between Iceberg connector and Spark Iceberg. + */ public class TestIcebergSparkCompatibility extends ProductTest {