Skip to content

Commit f5cba1e

Browse files
Fix TestRedshiftConnectorTest TestingConnectorBehavior
Also, adjust the failure message in testDecimalAvgPushdownForMaximumDecimalScale. Does not run in CI and became stale after: 6781fa3 Co-Authored-By: Grant Nicholas <[email protected]>
1 parent 83fb1ac commit f5cba1e

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

plugin/trino-redshift/src/test/java/io/trino/plugin/redshift/TestRedshiftConnectorTest.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
6767
{
6868
switch (connectorBehavior) {
6969
case SUPPORTS_COMMENT_ON_TABLE:
70+
return false;
71+
case SUPPORTS_COMMENT_ON_COLUMN:
72+
return true;
73+
7074
case SUPPORTS_CREATE_TABLE_WITH_TABLE_COMMENT:
7175
case SUPPORTS_CREATE_TABLE_WITH_COLUMN_COMMENT:
7276
return false;
@@ -82,10 +86,10 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
8286
case SUPPORTS_RENAME_TABLE_ACROSS_SCHEMAS:
8387
return false;
8488

85-
case SUPPORTS_AGGREGATION_PUSHDOWN_STDDEV:
86-
case SUPPORTS_AGGREGATION_PUSHDOWN_VARIANCE:
87-
case SUPPORTS_AGGREGATION_PUSHDOWN_COUNT_DISTINCT:
88-
return true;
89+
case SUPPORTS_AGGREGATION_PUSHDOWN_COVARIANCE:
90+
case SUPPORTS_AGGREGATION_PUSHDOWN_CORRELATION:
91+
case SUPPORTS_AGGREGATION_PUSHDOWN_REGRESSION:
92+
return false;
8993

9094
case SUPPORTS_JOIN_PUSHDOWN:
9195
case SUPPORTS_JOIN_PUSHDOWN_WITH_VARCHAR_EQUALITY:
@@ -536,9 +540,9 @@ public void testDecimalAvgPushdownForMaximumDecimalScale()
536540
.isInstanceOf(AssertionError.class)
537541
.hasMessageContaining("""
538542
elements not found:
539-
<(555555555555555555561728450.9938271605)>
543+
(555555555555555555561728450.9938271605)
540544
and elements not expected:
541-
<(555555555555555555561728450.9938271604)>
545+
(555555555555555555561728450.9938271604)
542546
""");
543547
}
544548
}

0 commit comments

Comments
 (0)