Skip to content

Commit f5945f8

Browse files
committed
Clean up test schema in connector tests
1 parent b475858 commit f5945f8

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -375,11 +375,15 @@ public void testCreateSchema()
375375
return;
376376
}
377377

378-
assertUpdate(createSchemaSql(schemaName));
379-
assertThat(query("SHOW SCHEMAS"))
380-
.skippingTypesCheck()
381-
.containsAll(format("VALUES '%s', '%s'", getSession().getSchema().orElseThrow(), schemaName));
382-
assertUpdate("DROP SCHEMA " + schemaName);
378+
try {
379+
assertUpdate(createSchemaSql(schemaName));
380+
assertThat(query("SHOW SCHEMAS"))
381+
.skippingTypesCheck()
382+
.containsAll(format("VALUES '%s', '%s'", getSession().getSchema().orElseThrow(), schemaName));
383+
}
384+
finally {
385+
assertUpdate("DROP SCHEMA IF EXISTS " + schemaName);
386+
}
383387
}
384388

385389
@Test

testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3527,11 +3527,15 @@ public void testCreateSchemaWithNonLowercaseOwnerName()
35273527
.setIdentity(Identity.ofUser("ADMIN"))
35283528
.build();
35293529
String schemaName = "test_schema_create_uppercase_owner_name_" + randomNameSuffix();
3530-
assertUpdate(newSession, createSchemaSql(schemaName));
3531-
assertThat(query(newSession, "SHOW SCHEMAS"))
3532-
.skippingTypesCheck()
3533-
.containsAll(format("VALUES '%s'", schemaName));
3534-
assertUpdate(newSession, "DROP SCHEMA " + schemaName);
3530+
try {
3531+
assertUpdate(newSession, createSchemaSql(schemaName));
3532+
assertThat(query(newSession, "SHOW SCHEMAS"))
3533+
.skippingTypesCheck()
3534+
.containsAll(format("VALUES '%s'", schemaName));
3535+
}
3536+
finally {
3537+
assertUpdate(newSession, "DROP SCHEMA IF EXISTS " + schemaName);
3538+
}
35353539
}
35363540

35373541
@Test

0 commit comments

Comments
 (0)