Skip to content

Commit bb41de4

Browse files
committed
Fix add_files_from_table due to wrong column count condition
1 parent 9ee3dd4 commit bb41de4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,8 +1700,8 @@ private Optional<ConnectorTableExecuteHandle> getTableHandleForAddFilesFromTable
17001700
Table icebergTable = catalog.loadTable(session, tableHandle.getSchemaTableName());
17011701

17021702
checkProcedureArgument(
1703-
icebergTable.schemas().size() >= sourceTable.getDataColumns().size(),
1704-
"Target table should have at least %d columns but got %d", sourceTable.getDataColumns().size(), icebergTable.schemas().size());
1703+
icebergTable.schema().columns().size() >= sourceTable.getDataColumns().size(),
1704+
"Target table should have at least %d columns but got %d", sourceTable.getDataColumns().size(), icebergTable.schema().columns().size());
17051705
checkProcedureArgument(
17061706
icebergTable.spec().fields().size() == sourceTable.getPartitionColumns().size(),
17071707
"Numbers of partition columns should be equivalent. target: %d, source: %d", icebergTable.spec().fields().size(), sourceTable.getPartitionColumns().size());

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/procedure/TestIcebergAddFilesProcedure.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ private void testAddFilesDifferentFileFormat(String hiveFormat, String icebergFo
124124
String hiveTableName = "test_add_files_" + randomNameSuffix();
125125
String icebergTableName = "test_add_files_" + randomNameSuffix();
126126

127-
assertUpdate("CREATE TABLE iceberg.tpch." + icebergTableName + " WITH (format = '" + icebergFormat + "') AS SELECT 1 x", 1);
128-
assertUpdate("CREATE TABLE hive.tpch." + hiveTableName + " WITH (format = '" + hiveFormat + "') AS SELECT 2 x", 1);
127+
assertUpdate("CREATE TABLE iceberg.tpch." + icebergTableName + " WITH (format = '" + icebergFormat + "') AS SELECT 1 x, 2 y", 1);
128+
assertUpdate("CREATE TABLE hive.tpch." + hiveTableName + " WITH (format = '" + hiveFormat + "') AS SELECT 3 x, 4 y", 1);
129129

130130
assertUpdate("ALTER TABLE " + icebergTableName + " EXECUTE add_files_from_table('tpch', '" + hiveTableName + "')");
131131

132-
assertQuery("SELECT * FROM " + icebergTableName, "VALUES 1, 2");
132+
assertQuery("SELECT * FROM " + icebergTableName, "VALUES (1, 2), (3, 4)");
133133

134134
assertUpdate("DROP TABLE hive.tpch." + hiveTableName);
135135
assertUpdate("DROP TABLE iceberg.tpch." + icebergTableName);

0 commit comments

Comments
 (0)