Skip to content

Commit a603ad8

Browse files
committed
Fix invalid scope in trino-faker pom
test-jar is not a valid value for <scope>. It's a valid value for <type> however for trino-faker these dependencies' correct scope is runtime and the type is jar. Before this change the build logged a warning about this: Warning: Some problems were encountered while building the effective model for io.trino:trino-faker:trino-plugin:466-SNAPSHOT Warning: 'dependencies.dependency.scope' for io.airlift:log:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 169, column 20 Warning: 'dependencies.dependency.scope' for io.airlift:log-manager:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 175, column 20 Warning: 'dependencies.dependency.scope' for io.trino:trino-client:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 181, column 20 Warning: Warning: It is highly recommended to fix these problems because they threaten the stability of your build. Warning: Warning: For this reason, future Maven versions might no longer support building such malformed projects.
1 parent de43869 commit a603ad8

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

plugin/trino-faker/pom.xml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,30 @@
102102
<scope>provided</scope>
103103
</dependency>
104104

105+
<dependency>
106+
<groupId>io.airlift</groupId>
107+
<artifactId>log</artifactId>
108+
<scope>runtime</scope>
109+
</dependency>
110+
111+
<dependency>
112+
<groupId>io.airlift</groupId>
113+
<artifactId>log-manager</artifactId>
114+
<scope>runtime</scope>
115+
</dependency>
116+
105117
<dependency>
106118
<groupId>io.airlift</groupId>
107119
<artifactId>units</artifactId>
108120
<scope>runtime</scope>
109121
</dependency>
110122

123+
<dependency>
124+
<groupId>io.trino</groupId>
125+
<artifactId>trino-client</artifactId>
126+
<scope>runtime</scope>
127+
</dependency>
128+
111129
<dependency>
112130
<groupId>io.airlift</groupId>
113131
<artifactId>junit-extensions</artifactId>
@@ -162,23 +180,5 @@
162180
<artifactId>junit-jupiter-api</artifactId>
163181
<scope>test</scope>
164182
</dependency>
165-
166-
<dependency>
167-
<groupId>io.airlift</groupId>
168-
<artifactId>log</artifactId>
169-
<scope>test-jar</scope>
170-
</dependency>
171-
172-
<dependency>
173-
<groupId>io.airlift</groupId>
174-
<artifactId>log-manager</artifactId>
175-
<scope>test-jar</scope>
176-
</dependency>
177-
178-
<dependency>
179-
<groupId>io.trino</groupId>
180-
<artifactId>trino-client</artifactId>
181-
<scope>test-jar</scope>
182-
</dependency>
183183
</dependencies>
184184
</project>

0 commit comments

Comments
 (0)