Add temporal data tests with INSERT in Presto

Author: findepi

presto-mysql/src/test/java/io/prestosql/plugin/mysql/TestMySqlTypeMapping.java

@@ -429,6 +429,8 @@ public void testDate()
                     .build();
             testCases.execute(getQueryRunner(), session, mysqlCreateAndInsert("tpch.test_date"));
             testCases.execute(getQueryRunner(), session, prestoCreateAsSelect(session, "test_date"));
+            testCases.execute(getQueryRunner(), session, prestoCreateAsSelect(getSession(), "test_date"));
+            testCases.execute(getQueryRunner(), session, prestoCreateAndInsert(session, "test_date"));
         }
     }
 
@@ -547,6 +549,11 @@ private DataSetup prestoCreateAsSelect(Session session, String tableNamePrefix)
         return new CreateAsSelectDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
     }
 
+    private DataSetup prestoCreateAndInsert(Session session, String tableNamePrefix)
+    {
+        return new CreateAndInsertDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
+    }
+
     private DataSetup mysqlCreateAndInsert(String tableNamePrefix)
     {
         return new CreateAndInsertDataSetup(mysqlServer::execute, tableNamePrefix);

presto-phoenix/src/test/java/io/prestosql/plugin/phoenix/TestPhoenixSqlTypeMapping.java

@@ -237,6 +237,8 @@ public void testDate()
                     .setTimeZoneKey(TimeZoneKey.getTimeZoneKey(timeZoneId))
                     .build();
             prestoTestCases.execute(getQueryRunner(), session, prestoCreateAsSelect(session, "test_date"));
+            prestoTestCases.execute(getQueryRunner(), session, prestoCreateAsSelect(getSession(), "test_date"));
+            prestoTestCases.execute(getQueryRunner(), session, prestoCreateAndInsert(session, "test_date"));
             phoenixTestCases.execute(getQueryRunner(), session, phoenixCreateAndInsert("tpch.test_date"));
         }
     }
@@ -414,6 +416,11 @@ private DataSetup prestoCreateAsSelect(Session session, String tableNamePrefix)
         return new CreateAsSelectDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
     }
 
+    private DataSetup prestoCreateAndInsert(Session session, String tableNamePrefix)
+    {
+        return new CreateAndInsertDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
+    }
+
     private DataSetup phoenixCreateAndInsert(String tableNamePrefix)
     {
         return new CreateAndInsertDataSetup(new PhoenixSqlExecutor(phoenixServer.getJdbcUrl()), tableNamePrefix);

presto-postgresql/src/test/java/io/prestosql/plugin/postgresql/TestPostgreSqlTypeMapping.java

@@ -945,6 +945,8 @@ public void testDate()
                     .build();
             testCases.execute(getQueryRunner(), session, postgresCreateAndInsert("tpch.test_date"));
             testCases.execute(getQueryRunner(), session, prestoCreateAsSelect(session, "test_date"));
+            testCases.execute(getQueryRunner(), session, prestoCreateAsSelect(getSession(), "test_date"));
+            testCases.execute(getQueryRunner(), session, prestoCreateAndInsert(session, "test_date"));
         }
     }
 
@@ -997,6 +999,8 @@ public void testTime(boolean insertWithPresto, ZoneId sessionZone)
 
         if (insertWithPresto) {
             tests.execute(getQueryRunner(), session, prestoCreateAsSelect(session, "test_time"));
+            tests.execute(getQueryRunner(), session, prestoCreateAsSelect(getSession(), "test_time"));
+            tests.execute(getQueryRunner(), session, prestoCreateAndInsert(session, "test_time"));
         }
         else {
             tests.execute(getQueryRunner(), session, postgresCreateAndInsert("tpch.test_time"));
@@ -1040,6 +1044,8 @@ public void testTimestamp(boolean insertWithPresto, ZoneId sessionZone)
 
         if (insertWithPresto) {
             tests.execute(getQueryRunner(), session, prestoCreateAsSelect(session, "test_timestamp"));
+            tests.execute(getQueryRunner(), session, prestoCreateAsSelect(getSession(), "test_timestamp"));
+            tests.execute(getQueryRunner(), session, prestoCreateAndInsert(session, "test_timestamp"));
         }
         else {
             tests.execute(getQueryRunner(), session, postgresCreateAndInsert("tpch.test_timestamp"));
@@ -1581,6 +1587,11 @@ private DataSetup prestoCreateAsSelect(Session session, String tableNamePrefix)
         return new CreateAsSelectDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
     }
 
+    private DataSetup prestoCreateAndInsert(Session session, String tableNamePrefix)
+    {
+        return new CreateAndInsertDataSetup(new PrestoSqlExecutor(getQueryRunner(), session), tableNamePrefix);
+    }
+
     private DataSetup postgresCreateAndInsert(String tableNamePrefix)
     {
         return new CreateAndInsertDataSetup(new JdbcSqlExecutor(postgreSqlServer.getJdbcUrl()), tableNamePrefix);