Rename NodeRepresentation identifier to descriptor

Author: gaurav8297

core/trino-main/src/main/java/io/trino/sql/planner/planprinter/JsonRenderer.java

@@ -48,7 +48,7 @@ private JsonRenderedNode renderJson(PlanRepresentation plan, NodeRepresentation
         return new JsonRenderedNode(
                 node.getId().toString(),
                 node.getName(),
-                node.getIdentifier(),
+                node.getDescriptor(),
                 node.getOutputs(),
                 node.getDetails(),
                 node.getEstimates(plan.getTypes()),
@@ -62,7 +62,7 @@ public static class JsonRenderedNode
     {
         private final String id;
         private final String name;
-        private final String identifier;
+        private final String descriptor;
         private final List<TypedSymbol> outputs;
         private final String details;
         private final List<PlanNodeStatsAndCostSummary> estimates;
@@ -72,7 +72,7 @@ public static class JsonRenderedNode
         public JsonRenderedNode(
                 String id,
                 String name,
-                String identifier,
+                String descriptor,
                 List<TypedSymbol> outputs,
                 String details,
                 List<PlanNodeStatsAndCostSummary> estimates,
@@ -81,7 +81,7 @@ public JsonRenderedNode(
         {
             this.id = requireNonNull(id, "id is null");
             this.name = requireNonNull(name, "name is null");
-            this.identifier = requireNonNull(identifier, "identifier is null");
+            this.descriptor = requireNonNull(descriptor, "descriptor is null");
             this.outputs = requireNonNull(outputs, "outputs is null");
             this.details = requireNonNull(details, "details is null");
             this.estimates = requireNonNull(estimates, "estimates is null");
@@ -102,9 +102,9 @@ public String getName()
         }
 
         @JsonProperty
-        public String getIdentifier()
+        public String getDescriptor()
         {
-            return identifier;
+            return descriptor;
         }
 
         @JsonProperty

core/trino-main/src/main/java/io/trino/sql/planner/planprinter/NodeRepresentation.java

@@ -37,7 +37,7 @@ public class NodeRepresentation
     private final PlanNodeId id;
     private final String name;
     private final String type;
-    private final String identifier;
+    private final String descriptor;
     private final List<TypedSymbol> outputs;
     private final List<PlanNodeId> children;
     private final List<PlanFragmentId> remoteSources;
@@ -52,7 +52,7 @@ public NodeRepresentation(
             PlanNodeId id,
             String name,
             String type,
-            String identifier,
+            String descriptor,
             List<TypedSymbol> outputs,
             Optional<PlanNodeStats> stats,
             List<PlanNodeStatsEstimate> estimatedStats,
@@ -64,7 +64,7 @@ public NodeRepresentation(
         this.id = requireNonNull(id, "id is null");
         this.name = requireNonNull(name, "name is null");
         this.type = requireNonNull(type, "type is null");
-        this.identifier = requireNonNull(identifier, "identifier is null");
+        this.descriptor = requireNonNull(descriptor, "descriptor is null");
         this.outputs = requireNonNull(outputs, "outputs is null");
         this.stats = requireNonNull(stats, "stats is null");
         this.estimatedStats = requireNonNull(estimatedStats, "estimatedStats is null");
@@ -107,9 +107,9 @@ public String getType()
         return type;
     }
 
-    public String getIdentifier()
+    public String getDescriptor()
     {
-        return identifier;
+        return descriptor;
     }
 
     public List<TypedSymbol> getOutputs()

core/trino-main/src/main/java/io/trino/sql/planner/planprinter/PlanPrinter.java

@@ -1560,25 +1560,25 @@ public NodeRepresentation addNode(PlanNode node, String name)
             return addNode(node, name, "");
         }
 
-        public NodeRepresentation addNode(PlanNode node, String name, String identifier)
+        public NodeRepresentation addNode(PlanNode node, String name, String descriptor)
         {
-            return addNode(node, name, identifier, node.getSources(), Optional.empty());
+            return addNode(node, name, descriptor, node.getSources(), Optional.empty());
         }
 
-        public NodeRepresentation addNode(PlanNode node, String name, String identifier, Optional<PlanNodeStatsAndCostSummary> reorderJoinStatsAndCost)
+        public NodeRepresentation addNode(PlanNode node, String name, String descriptor, Optional<PlanNodeStatsAndCostSummary> reorderJoinStatsAndCost)
         {
-            return addNode(node, name, identifier, node.getSources(), reorderJoinStatsAndCost);
+            return addNode(node, name, descriptor, node.getSources(), reorderJoinStatsAndCost);
         }
 
-        public NodeRepresentation addNode(PlanNode node, String name, String identifier, List<PlanNode> children, Optional<PlanNodeStatsAndCostSummary> reorderJoinStatsAndCost)
+        public NodeRepresentation addNode(PlanNode node, String name, String descriptor, List<PlanNode> children, Optional<PlanNodeStatsAndCostSummary> reorderJoinStatsAndCost)
         {
-            return addNode(node, name, identifier, ImmutableList.of(node.getId()), children, ImmutableList.of(), reorderJoinStatsAndCost);
+            return addNode(node, name, descriptor, ImmutableList.of(node.getId()), children, ImmutableList.of(), reorderJoinStatsAndCost);
         }
 
         public NodeRepresentation addNode(
                 PlanNode rootNode,
                 String name,
-                String identifier,
+                String descriptor,
                 List<PlanNodeId> allNodes,
                 List<PlanNode> children,
                 List<PlanFragmentId> remoteSources,
@@ -1596,7 +1596,7 @@ public NodeRepresentation addNode(
                     rootNode.getId(),
                     name,
                     rootNode.getClass().getSimpleName(),
-                    identifier,
+                    descriptor,
                     rootNode.getOutputSymbols().stream()
                             .map(s -> new TypedSymbol(s, types.get(s).getDisplayName()))
                             .collect(toImmutableList()),

core/trino-main/src/main/java/io/trino/sql/planner/planprinter/TextRenderer.java

@@ -65,7 +65,7 @@ private String writeTextOutput(StringBuilder output, PlanRepresentation plan, In
     {
         output.append(indent.nodeIndent())
                 .append(node.getName())
-                .append(node.getIdentifier())
+                .append(node.getDescriptor())
                 .append("\n");
 
         String columns = node.getOutputs().stream()