Skip to content

Commit 416dada

Browse files
chenjian2664kokosing
authored andcommitted
Fix Ignite schema change operation tests failure
1 parent c999795 commit 416dada

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

plugin/trino-ignite/src/test/java/io/trino/plugin/ignite/TestIgniteConnectorTest.java

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import io.trino.testing.TestingConnectorBehavior;
2121
import io.trino.testing.sql.SqlExecutor;
2222
import io.trino.testing.sql.TestTable;
23+
import io.trino.testng.services.Flaky;
24+
import org.intellij.lang.annotations.Language;
2325
import org.testng.SkipException;
2426
import org.testng.annotations.Test;
2527

@@ -37,6 +39,10 @@
3739
public class TestIgniteConnectorTest
3840
extends BaseJdbcConnectorTest
3941
{
42+
private static final String SCHEMA_CHANGE_OPERATION_FAIL_ISSUE = "https://github.com/trinodb/trino/issues/14391";
43+
@Language("RegExp")
44+
private static final String SCHEMA_CHANGE_OPERATION_FAIL_MATCH = "Schema change operation failed: Thread got interrupted while trying to acquire table lock.";
45+
4046
private TestingIgniteServer igniteServer;
4147

4248
@Override
@@ -317,7 +323,9 @@ protected void verifyConcurrentAddColumnFailurePermissible(Exception e)
317323
assertThat(e).hasMessage("Schema change operation failed: Thread got interrupted while trying to acquire table lock.");
318324
}
319325

326+
@Test
320327
@Override
328+
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
321329
public void testDropAndAddColumnWithSameName()
322330
{
323331
// Override because Ignite can access old data after dropping and adding a column with same name
@@ -330,6 +338,38 @@ public void testDropAndAddColumnWithSameName()
330338
}
331339
}
332340

341+
@Test
342+
@Override
343+
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
344+
public void testAddColumn()
345+
{
346+
super.testAddColumn();
347+
}
348+
349+
@Test
350+
@Override
351+
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
352+
public void testDropColumn()
353+
{
354+
super.testDropColumn();
355+
}
356+
357+
@Test
358+
@Override
359+
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
360+
public void testAlterTableAddLongColumnName()
361+
{
362+
super.testAlterTableAddLongColumnName();
363+
}
364+
365+
@Test(dataProvider = "testColumnNameDataProvider")
366+
@Override
367+
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
368+
public void testAddAndDropColumnName(String columnName)
369+
{
370+
super.testAddAndDropColumnName(columnName);
371+
}
372+
333373
@Override
334374
protected TestTable simpleTable()
335375
{

0 commit comments

Comments
 (0)