Skip to content

Commit 35eda7d

Browse files
krvikashfindepi
authored andcommitted
Remove unnecessary metadata call in DeltaLakeMetadata#beginMerge
1 parent 79d3043 commit 35eda7d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,12 +1340,12 @@ public ConnectorInsertTableHandle beginInsert(ConnectorSession session, Connecto
13401340
// This check acts as a safeguard in cases where the input columns may differ from the table metadata case-sensitively
13411341
checkAllColumnsPassedOnInsert(tableMetadata, inputColumns);
13421342

1343-
return createInsertHandle(session, retryMode, table, inputColumns, tableMetadata);
1343+
return createInsertHandle(session, retryMode, table, inputColumns);
13441344
}
13451345

1346-
private DeltaLakeInsertTableHandle createInsertHandle(ConnectorSession session, RetryMode retryMode, DeltaLakeTableHandle table, List<DeltaLakeColumnHandle> inputColumns, ConnectorTableMetadata tableMetadata)
1346+
private DeltaLakeInsertTableHandle createInsertHandle(ConnectorSession session, RetryMode retryMode, DeltaLakeTableHandle table, List<DeltaLakeColumnHandle> inputColumns)
13471347
{
1348-
String tableLocation = getLocation(tableMetadata.getProperties());
1348+
String tableLocation = table.getLocation();
13491349
try {
13501350
TrinoFileSystem fileSystem = fileSystemFactory.create(session);
13511351
return new DeltaLakeInsertTableHandle(
@@ -1508,13 +1508,11 @@ public ConnectorMergeTableHandle beginMerge(ConnectorSession session, ConnectorT
15081508
}
15091509
checkWriteSupported(session, handle);
15101510

1511-
ConnectorTableMetadata tableMetadata = getTableMetadata(session, handle);
1512-
15131511
List<DeltaLakeColumnHandle> inputColumns = getColumns(handle.getMetadataEntry()).stream()
15141512
.filter(column -> column.getColumnType() != SYNTHESIZED)
15151513
.collect(toImmutableList());
15161514

1517-
DeltaLakeInsertTableHandle insertHandle = createInsertHandle(session, retryMode, handle, inputColumns, tableMetadata);
1515+
DeltaLakeInsertTableHandle insertHandle = createInsertHandle(session, retryMode, handle, inputColumns);
15181516

15191517
return new DeltaLakeMergeTableHandle(handle, insertHandle);
15201518
}

0 commit comments

Comments
 (0)