Skip to content

Commit 1fd172e

Browse files
committed
Use URI type in OpenLineage config
1 parent ae48147 commit 1fd172e

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

plugin/trino-openlineage/src/main/java/io/trino/plugin/openlineage/config/http/OpenLineageClientHttpTransportConfig.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import io.airlift.units.MinDuration;
2222
import jakarta.validation.constraints.NotNull;
2323

24+
import java.net.URI;
2425
import java.util.HashMap;
2526
import java.util.List;
2627
import java.util.Map;
@@ -32,22 +33,22 @@
3233

3334
public class OpenLineageClientHttpTransportConfig
3435
{
35-
private String url;
36+
private URI url;
3637
private String endpoint;
3738
private Optional<String> apiKey = Optional.empty();
3839
private Duration timeout = new Duration(5000, TimeUnit.MILLISECONDS);
3940
private Map<String, String> headers = new HashMap<>();
4041
private Map<String, String> urlParams = new HashMap<>();
4142

4243
@NotNull
43-
public String getUrl()
44+
public URI getUrl()
4445
{
4546
return url;
4647
}
4748

4849
@Config("openlineage-event-listener.transport.url")
4950
@ConfigDescription("URL of receiving server. Explicitly set the scheme https:// to use symmetric encryption")
50-
public OpenLineageClientHttpTransportConfig setUrl(String url)
51+
public OpenLineageClientHttpTransportConfig setUrl(URI url)
5152
{
5253
this.url = url;
5354
return this;

plugin/trino-openlineage/src/main/java/io/trino/plugin/openlineage/transport/OpenLineageTransport.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,5 @@
1717

1818
public interface OpenLineageTransport
1919
{
20-
Transport buildTransport()
21-
throws Exception;
20+
Transport buildTransport();
2221
}

plugin/trino-openlineage/src/main/java/io/trino/plugin/openlineage/transport/http/OpenLineageHttpTransport.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
public class OpenLineageHttpTransport
3030
implements OpenLineageTransport
3131
{
32-
private final String url;
32+
private final URI url;
3333
private final String endpoint;
3434
private final int timeout;
3535
private final ApiKeyTokenProvider apiKey;
@@ -64,11 +64,10 @@ public OpenLineageHttpTransport(OpenLineageClientHttpTransportConfig config)
6464

6565
@Override
6666
public HttpTransport buildTransport()
67-
throws Exception
6867
{
6968
return new HttpTransport(
7069
new HttpConfig(
71-
new URI(this.url),
70+
this.url,
7271
this.endpoint,
7372
null,
7473
this.timeout,

plugin/trino-openlineage/src/test/java/io/trino/plugin/openlineage/TestOpenLineageClientHttpTransportConfig.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import io.trino.plugin.openlineage.config.http.OpenLineageClientHttpTransportConfig;
2020
import org.junit.jupiter.api.Test;
2121

22+
import java.net.URI;
2223
import java.util.Map;
2324

2425
import static io.airlift.configuration.testing.ConfigAssertions.assertFullMapping;
@@ -41,6 +42,7 @@ void testDefaults()
4142

4243
@Test
4344
void testExplicitPropertyMappings()
45+
throws Exception
4446
{
4547
Map<String, String> properties = ImmutableMap.<String, String>builder()
4648
.put("openlineage-event-listener.transport.url", "http://testurl")
@@ -53,7 +55,7 @@ void testExplicitPropertyMappings()
5355
.buildOrThrow();
5456

5557
OpenLineageClientHttpTransportConfig expected = new OpenLineageClientHttpTransportConfig()
56-
.setUrl("http://testurl")
58+
.setUrl(new URI("http://testurl"))
5759
.setEndpoint("/test/endpoint")
5860
.setApiKey("dummy")
5961
.setTimeout(Duration.valueOf("30s"))

0 commit comments

Comments
 (0)