Skip to content

Commit 1b0a011

Browse files
raunaqmorarkalosipiuk
authored andcommitted
Clean up code comments in JdbcJoinPushdownUtil
1 parent ab70abe commit 1b0a011

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcJoinPushdownUtil.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public static Optional<PreparedQuery> implementJoinCostAware(
6161
}
6262

6363
/**
64-
* Common implementation of AUTOMATIC join pushdown strategy to by used in SEP Jdbc connectors
64+
* Common implementation of AUTOMATIC join pushdown strategy used in Jdbc connectors
6565
*/
6666
public static boolean shouldPushDownJoinCostAware(
6767
ConnectorSession session,
@@ -106,9 +106,9 @@ public static boolean shouldPushDownJoinCostAware(
106106

107107
double joinDataSize = statistics.getJoinStatistics().get().getDataSize();
108108
if (joinDataSize < getJoinPushdownAutomaticJoinToTablesRatio(session) * (leftDataSize + rightDataSize)) {
109-
// This is poor man's estimation if it makes more sense to perform join in source database or SEP.
110-
// The assumption here is that cost of performing join in source database is less than or equal to cost of join in SEP.
111-
// We resolve tie for pessimistic case (both join costs equal) on cost of sending the data from source database to SEP.
109+
// This is poor man's estimation if it makes more sense to perform join in source database or Trino.
110+
// The assumption here is that cost of performing join in source database is less than or equal to cost of join in Trino.
111+
// We resolve tie for pessimistic case (both join costs equal) on cost of sending the data from source database to Trino.
112112
LOG.debug("triggering join pushdown for %s", joinSignature);
113113
return true;
114114
}

0 commit comments

Comments
 (0)