Support HTTP methods other than POST

Support HTTP methods other than POST

Author: danielbelchior

docs/src/main/sphinx/admin/event-listeners-http.md

@@ -75,6 +75,10 @@ event-listener.config-files=etc/http-event-listener.properties,...
     [](http-event-listener-custom-headers) for more details
   - Empty
 
+* - http-event-listener.connect-http-method
+  - Specifies the HTTP method to use for the request. Supported values are POST and PUT.
+  - `POST`
+
 * - http-event-listener.connect-retry-count
   - The number of retries on server error. A server is considered to be
     in an error state when the response code is 500 or higher

plugin/trino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListener.java

@@ -42,7 +42,6 @@
 import static com.google.common.net.MediaType.JSON_UTF_8;
 import static io.airlift.concurrent.Threads.daemonThreadsNamed;
 import static io.airlift.http.client.JsonBodyGenerator.jsonBodyGenerator;
-import static io.airlift.http.client.Request.Builder.preparePost;
 import static io.airlift.http.client.StatusResponseHandler.StatusResponse;
 import static io.airlift.http.client.StatusResponseHandler.createStatusResponseHandler;
 import static java.util.Objects.requireNonNull;
@@ -75,6 +74,7 @@ public class HttpEventListener
     private final double backoffBase;
     private final Map<String, String> httpHeaders;
     private final URI ingestUri;
+    private final HttpEventListenerHttpMethod httpMethod;
     private final ScheduledExecutorService executor;
 
     @Inject
@@ -100,6 +100,7 @@ public HttpEventListener(
         this.retryDelay = config.getRetryDelay();
         this.maxDelay = config.getMaxDelay();
         this.backoffBase = config.getBackoffBase();
+        this.httpMethod = config.getHttpMethod();
         this.httpHeaders = ImmutableMap.copyOf(config.getHttpHeaders());
 
         try {
@@ -144,7 +145,8 @@ public void splitCompleted(SplitCompletedEvent splitCompletedEvent)
 
     private void sendLog(BodyGenerator eventBodyGenerator, String queryId)
     {
-        Request request = preparePost()
+        Request request = Request.builder()
+                .setMethod(httpMethod.name())
                 .addHeaders(Multimaps.forMap(httpHeaders))
                 .addHeader(CONTENT_TYPE, JSON_UTF_8.toString())
                 .setUri(ingestUri)

plugin/trino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java

@@ -33,6 +33,7 @@ public class HttpEventListenerConfig
     private Duration maxDelay = Duration.valueOf("1m");
     private final EnumSet<HttpEventListenerEventType> loggedEvents = EnumSet.noneOf(HttpEventListenerEventType.class);
     private String ingestUri;
+    private HttpEventListenerHttpMethod httpMethod = HttpEventListenerHttpMethod.POST;
     private Map<String, String> httpHeaders = ImmutableMap.of();
 
     @ConfigDescription("Will log io.trino.spi.eventlistener.QueryCreatedEvent")
@@ -94,6 +95,20 @@ public HttpEventListenerConfig setIngestUri(String ingestUri)
         return this;
     }
 
+    @NotNull
+    public HttpEventListenerHttpMethod getHttpMethod()
+    {
+        return httpMethod;
+    }
+
+    @ConfigDescription("Specifies the HTTP method to use for the request. Supported values are POST (default) and PUT.")
+    @Config("http-event-listener.connect-http-method")
+    public HttpEventListenerConfig setHttpMethod(HttpEventListenerHttpMethod httpMethod)
+    {
+        this.httpMethod = httpMethod;
+        return this;
+    }
+
     public Map<String, String> getHttpHeaders()
     {
         return httpHeaders;

plugin/trino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerHttpMethod.java

@@ -0,0 +1,20 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.trino.plugin.httpquery;
+
+public enum HttpEventListenerHttpMethod
+{
+    POST,
+    PUT
+}

plugin/trino-http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java

@@ -37,6 +37,7 @@ void testDefaults()
                 .setRetryDelay(Duration.succinctDuration(1, TimeUnit.SECONDS))
                 .setMaxDelay(Duration.succinctDuration(1, TimeUnit.MINUTES))
                 .setBackoffBase(2.0)
+                .setHttpMethod(HttpEventListenerHttpMethod.POST)
                 .setLogCompleted(false)
                 .setLogCreated(false)
                 .setLogSplit(false));
@@ -53,6 +54,7 @@ void testExplicitPropertyMappings()
                 "http-event-listener.connect-ingest-uri", "http://example.com:8080/api",
                 "http-event-listener.connect-http-headers", "Authorization: Trust Me, Cache-Control: no-cache",
                 "http-event-listener.connect-retry-count", "2",
+                "http-event-listener.connect-http-method", "PUT",
                 "http-event-listener.connect-retry-delay", "101s",
                 "http-event-listener.connect-backoff-base", "1.5",
                 "http-event-listener.connect-max-delay", "10m");
@@ -64,6 +66,7 @@ void testExplicitPropertyMappings()
                 .setIngestUri("http://example.com:8080/api")
                 .setHttpHeaders(List.of("Authorization: Trust Me", "Cache-Control: no-cache"))
                 .setRetryCount(2)
+                .setHttpMethod(HttpEventListenerHttpMethod.PUT)
                 .setRetryDelay(Duration.succinctDuration(101, TimeUnit.SECONDS))
                 .setBackoffBase(1.5)
                 .setMaxDelay(Duration.succinctDuration(10, TimeUnit.MINUTES));