SQLAlchemy 2.0 Compatibility

In the do_execute function of SQLAlchemy dialect, an if statement was accessing context.should_autocommit.
This property has been removed in SQLAlchemy 2.0.
To fix, the if statement can simply be removed as it is no longer needed.

Author: mathiasritter

.github/workflows/ci.yml

@@ -58,6 +58,8 @@ jobs:
           - { python: "3.11", trino: "351", sqlalchemy: "~=1.4.0" }  # first Trino version
           # Test with sqlalchemy 1.3
           - { python: "3.11", trino: "latest", sqlalchemy: "~=1.3.0" }
+          # Test with sqlalchemy 2.0
+          - { python: "3.11", trino: "latest", sqlalchemy: "~=2.0.0b4" }
     env:
       TRINO_VERSION: "${{ matrix.trino }}"
     steps:

setup.py

@@ -26,7 +26,7 @@
     version = str(ast.literal_eval(trino_version.group(1)))
 
 kerberos_require = ["requests_kerberos"]
-sqlalchemy_require = ["sqlalchemy~=1.3"]
+sqlalchemy_require = ["sqlalchemy >= 1.3"]
 external_authentication_token_cache_require = ["keyring"]
 
 # We don't add localstorage_require to all_require as users must explicitly opt in to use keyring.
@@ -39,7 +39,7 @@
     "pytest",
     "pytest-runner",
     "click",
-    "sqlalchemy_utils",
+    "sqlalchemy_utils >= 0.39.0",
     "pre-commit",
     "black",
     "isort",
@@ -79,7 +79,7 @@
         "Programming Language :: Python :: Implementation :: PyPy",
         "Topic :: Database :: Front-Ends",
     ],
-    python_requires='>=3.7',
+    python_requires=">=3.7",
     install_requires=["pytz", "requests", "tzlocal"],
     extras_require={
         "all": all_require,

trino/sqlalchemy/dialect.py

@@ -363,11 +363,6 @@ def do_execute(
         self, cursor: Cursor, statement: str, parameters: Tuple[Any, ...], context: DefaultExecutionContext = None
     ):
         cursor.execute(statement, parameters)
-        if context and context.should_autocommit:
-            # SQL statement only submitted to Trino server when cursor.fetch*() is called.
-            # For DDL (CREATE/ALTER/DROP) and DML (INSERT/UPDATE/DELETE) statement, call cursor.description
-            # to force submit statement immediately.
-            cursor.description  # noqa
 
     def do_rollback(self, dbapi_connection: trino_dbapi.Connection):
         if dbapi_connection.transaction is not None: