Skip to content

Upgrade to Java 21 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ebyhr wants to merge 2 commits into from
Closed

Upgrade to Java 21 #149

ebyhr wants to merge 2 commits into from

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 5, 2024 •
edited
Loading

Fixes #79
trinodb/trino#20010 upgraded Java to 21 in Trino

@ebyhr
Add org.mvel:mvel2 dependency
6ba295d 
This is a prerequisite for Java 21.
@cla-bot cla-bot bot added the cla-signed label Jan 5, 2024
@ebyhr ebyhr changed the title Ebi/java 21 Upgrade to Java 21 Jan 5, 2024
@mosabua
Copy link
Member

mosabua commented Jan 5, 2024

Nice .. do we want to upgrade now, wait until Trino is on Java 21 or wait even longer? Wdyt @vishalya @willmostly @Chaho12

Maybe we can change it to be able to build with Java 21 (upgrade dependency) .. but not require it yet.

mosabua
mosabua previously requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho we should at least wait until Trino requires Java 21 to require Java 21 for Trino Gateway.

mosabua
mosabua reviewed Jan 5, 2024
View reviewed changes
@Chaho12
Copy link
Member

Chaho12 commented Jan 6, 2024

I agree, Trino doesn't officially require Java 21 as of now, and not many users are using java 21 so I think we should wait for a while.
Are there any big performance improvement with new version?

@mosabua
Copy link
Member

mosabua commented Jan 8, 2024

I think we should pull this PR apart and merge the update of the dependency to allow building with Java 21 .. and then update to Java 21 after a release or two

@ebyhr ebyhr dismissed mosabua’s stale review January 9, 2024 00:04

Java in Trino is upgraded to 21

@mosabua
Copy link
Member

mosabua commented Jan 9, 2024

Cherri picked mvel upgrade into #156

@mosabua
Copy link
Member

mosabua commented Jan 24, 2024

We should look at updating and verifying dependencies first .. or at least rebase and test this. Team discussion is positive about going to Java 21 in line with Trino soon though.

@ebyhr ebyhr closed this Jan 31, 2024
@ebyhr ebyhr deleted the ebi/java-21 branch January 31, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosabua mosabua mosabua left review comments

Assignees

No one assigned

Labels

cla-signed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to Java 21

4 participants

@ebyhr @mosabua @Chaho12