Skip to content

Commit f0cd177

Browse files
committed
Consolidate failed log messages
1 parent 164a178 commit f0cd177

File tree

1 file changed

+36
-18
lines changed

1 file changed

+36
-18
lines changed

packages/cli-v3/src/commands/deploy.ts

Lines changed: 36 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,41 +1203,59 @@ async function handleNativeBuildServerDeploy({
12031203
return process.exit(0);
12041204
}
12051205
case "failed": {
1206-
queuedSpinnerStopped
1207-
? log.error("Deployment failed")
1208-
: $queuedSpinner.stop("Deployment failed");
1209-
1210-
if (finalDeploymentEvent.message) {
1211-
log.error(chalk.bold(chalkError(finalDeploymentEvent.message)));
1206+
if (!queuedSpinnerStopped) {
1207+
$queuedSpinner.stop("Deployment failed");
12121208
}
1209+
1210+
log.error(
1211+
chalk.bold(
1212+
chalkError(
1213+
"Deployment failed" +
1214+
(finalDeploymentEvent.message ? `: ${finalDeploymentEvent.message}` : "")
1215+
)
1216+
)
1217+
);
1218+
12131219
throw new OutroCommandError(
12141220
`Version ${deployment.version} deployment failed ${
12151221
isLinksSupported ? `| ${cliLink("View deployment", rawDeploymentLink)}` : ""
12161222
}`
12171223
);
12181224
}
12191225
case "timed_out": {
1220-
queuedSpinnerStopped
1221-
? log.error("Deployment timed out")
1222-
: $queuedSpinner.stop("Deployment timed out");
1223-
1224-
if (finalDeploymentEvent.message) {
1225-
log.error(chalk.bold(chalkError(finalDeploymentEvent.message)));
1226+
if (!queuedSpinnerStopped) {
1227+
$queuedSpinner.stop("Deployment timed out");
12261228
}
1229+
1230+
log.error(
1231+
chalk.bold(
1232+
chalkError(
1233+
"Deployment timed out" +
1234+
(finalDeploymentEvent.message ? `: ${finalDeploymentEvent.message}` : "")
1235+
)
1236+
)
1237+
);
1238+
12271239
throw new OutroCommandError(
12281240
`Version ${deployment.version} deployment timed out ${
12291241
isLinksSupported ? `| ${cliLink("View deployment", rawDeploymentLink)}` : ""
12301242
}`
12311243
);
12321244
}
12331245
case "canceled": {
1234-
queuedSpinnerStopped
1235-
? log.error("Deployment was canceled")
1236-
: $queuedSpinner.stop("Deployment was canceled");
1237-
1238-
if (finalDeploymentEvent.message) {
1239-
log.error(chalk.bold(chalkError(finalDeploymentEvent.message)));
1246+
if (!queuedSpinnerStopped) {
1247+
$queuedSpinner.stop("Deployment was canceled");
12401248
}
1249+
1250+
log.error(
1251+
chalk.bold(
1252+
chalkError(
1253+
"Deployment was canceled" +
1254+
(finalDeploymentEvent.message ? `: ${finalDeploymentEvent.message}` : "")
1255+
)
1256+
)
1257+
);
1258+
12411259
throw new OutroCommandError(
12421260
`Version ${deployment.version} deployment canceled ${
12431261
isLinksSupported ? `| ${cliLink("View deployment", rawDeploymentLink)}` : ""

0 commit comments

Comments
 (0)