Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sudo-rs to compile on FreeBSD #869

Open
3 tasks
squell opened this issue Oct 8, 2024 · 2 comments
Open
3 tasks

Get sudo-rs to compile on FreeBSD #869

squell opened this issue Oct 8, 2024 · 2 comments
Labels
enhancement New feature or request freebsd

Comments

@squell
Copy link
Member

squell commented Oct 8, 2024

You are allowed to cut corners here, e.g. disable some parts (preferably not too much).

This PR has a few easy intermediate steps:

  • sudo-rs compiles but doesn't actually work (i.e. crashes or does the wrong thing)
  • sudo-rs compiles and prints the help accurately
  • sudo-rs is able to launch a process (without any feature we actually care about such as authenticating the user properly, setting the timestamps, and so on)

Getting PAM and any other system interface working properly is a separate issue. The goal of this PR is to get a baseline.

Needless to say, this should not result in a PR on our current main, but rather something that lives in a (longer-lived) branch.

Don't forget to re-introduce the "Using this version of sudo-rs is likely to break your system" SUDO_RS_IS_UNSTABLE feature for this branch (or similar precaution)

@squell squell added enhancement New feature or request freebsd labels Oct 8, 2024
@squell
Copy link
Member Author

squell commented Oct 9, 2024

Note, if #862 is merged we already have a temporary "foolproof" since sudo wil refuse operation on FreeBSD.

@bjorn3
Copy link
Collaborator

bjorn3 commented Oct 9, 2024

The existing kernel_check already causes sudo-rs to refuse to run on FreeBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request freebsd
Projects
None yet
Development

No branches or pull requests

2 participants