Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages in case of configuration errors #835

Open
squell opened this issue Mar 13, 2024 · 1 comment
Open

Improved error messages in case of configuration errors #835

squell opened this issue Mar 13, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@squell
Copy link
Member

squell commented Mar 13, 2024

Describe the feature you'd like see implemented in sudo-rs
Improved error messages in case of a configuration mistake (see also #832).

For example:

  • A missing /etc/sudoers file (right now: "cannot load configuration: no such file or directory", I believe)
  • PAM configuration files missing

In particular, perhaps some error messages are still a bit "developer"-ish (e.g. lazily using Rust's "{:?}" to format them).

What problem can be solved with this feature?
Easier adoption of sudo-rs; for many users installing it will be a "manual" proces and having more informative error messages can help in troubleshooting mistakes caused by differences between Todd Miller's sudo and ours.

@squell squell added the enhancement New feature or request label Mar 13, 2024
@squell squell added this to the Milestone 4 milestone Mar 13, 2024
@squell squell changed the title #832 Improved error messages in case of configuration errors Mar 13, 2024
@rnijveld
Copy link
Collaborator

The issue with PAM configuration files missing is that a missing service configuration in /etc/pam.d/[service] is very much a valid configuration, and automatically falls back to /etc/pam.conf. If that is what a system administrator wants to configure then they should be able to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants