Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remembered custom gas limit in send form is not displayed #8655

Open
tomasklim opened this issue Jun 7, 2023 · 2 comments · May be fixed by #13145
Open

Remembered custom gas limit in send form is not displayed #8655

tomasklim opened this issue Jun 7, 2023 · 2 comments · May be fixed by #13145
Assignees
Labels
bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine

Comments

@tomasklim
Copy link
Member

tomasklim commented Jun 7, 2023

Describe the bug

  • custom gas limit in input is 21000 in case I set gas limit to a different one in previous send form session
  • Despite the incorrectness in the custom gas limit input, it is correct in the review modal

Info:

  • Suite Version: 22.6.0

How to reproduce

  1. Go to send form
  2. Fill it with custom gas limit
  3. Leave it
  4. Check it again. It is 21000. (there is flash of the correct one but then it changes to 21k)
  5. sign tx - gas limit is correct

Expected behavior

  • gas limit is correct

Screenshots

  1. first session
    Screenshot 2023-06-07 at 14 47 41
  2. leave form and enter again
    Screenshot 2023-06-07 at 14 47 55
  3. tadá, new session, custom input incorrect but review modal correct
    Screenshot 2023-06-07 at 14 48 08
@tomasklim tomasklim added bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine labels Jun 7, 2023
@tomasklim tomasklim added this to the Suite Trends milestone Jan 23, 2024
@tomasklim tomasklim mentioned this issue Jan 24, 2024
@tomasklim
Copy link
Member Author

tomasklim commented Apr 4, 2024

@AdamSchinzel do you think that it makes sense to store gas limit and gas price? I think it does not as it can change over time (especially gas price). I would not store that custom fee was chosen at all.

@AdamSchinzel
Copy link
Contributor

Hmm maybe it makes sense not to store it because of faster changes due to e. g. bull market, I would say user may not even recognize it so let's not store it

@tomasklim tomasklim linked a pull request Jul 2, 2024 that will close this issue
@tomasklim tomasklim self-assigned this Jul 11, 2024
@tomasklim tomasklim removed this from the Suite Trends H1/2024 milestone Aug 10, 2024
@tomasklim tomasklim moved this to 🎯 To do in Suite Desktop Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected EVM Issues related to networks based on Ethereum Virtual Machine
Projects
Status: 🎯 To do
Development

Successfully merging a pull request may close this issue.

2 participants