Address poisoning attack: Label unverified token transactions in TX detail

[mkolar242]

BACKGROUND

Related to #7278

Scammers employ a similar logic to that of zero-value transactions by utilizing unverified tokens that hold no fiat value but still carry a positive number of units in the transaction.

Example of the token: https://etherscan.io/token/0x8744dab2fa43055130a85c70d6b0676a82ae4704
Transaction example: https://etherscan.io/tx/0xfd7788d4ac55a9b1024d39a5d124f9e2012fc2dca197daa10c12e178d50b26ec

PROPOSED CHANGES

• Check the token contract address against Ethereum definitions
• If the contract address is not in Ethereum definitions label tx in the tx history
• Design remains as it is

[sime]

Could be done in combination with #8007

[Hannsek]

Restrict copying the address from tx labeled as posioned.

[zaplmi]

An effective and hopfeully simple way to prevent this could be to add a warning reminding users that copying an address from your transaction history is always unsafe. They'd see it every time they copy from their history, with an option to hide it. The same goes for BTC; address re-use isn't any good to anyone. It damages privacy and makes UTXO management confusing.

[etherscan.io] has something like that for dodgy tokens. We could extend this to every copy and paste of addresses in Suite. This way, we don't even have to have a whitelist/blacklist, which would be imperfect anyway.

proposal:

example from Etherscan:

[Hannsek]

recap:

• check the token contract address against ethereum definitions
• if the contract address is not in ethereum definitions label tx in the tx history
• restrict copying the address from the tx history and also from tx detail
• if one tx will contain not-scammy and scammy tokens, do not label the transaction as scammy, but follow the previous point for the scammy address –> restrict copying this address

[bosomt]

QA OK

Info:

• Suite version: web 24.2.0 (d0e9a1c)
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0
• OS: MacIntel
• Screen: 1915x1244
• Device: Trezor T2B1 2.6.4 regular (revision 42e9ed0e09033d474dee1a560fe5870646fa440e)
• Transport: BridgeTransport 2.0.33