Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW hash check fix Sentry reporting #16584

Closed
Lemonexe opened this issue Jan 24, 2025 · 1 comment · Fixed by #16585, #16652 or #16682
Closed

FW hash check fix Sentry reporting #16584

Lemonexe opened this issue Jan 24, 2025 · 1 comment · Fixed by #16585, #16652 or #16682
Assignees
@Lemonexe
Labels
bug Something isn't working as expected sentry Reports linked from Sentry.io or Sentry enhancements

Comments

@Lemonexe
Copy link
Contributor

Lemonexe commented Jan 24, 2025 •
edited
Loading

  • correctly append errorPayload to sentry errors/warnings (currently broken!)
  • only report other-error on attempt 3 (meaning retries maxed), not errors received in meantime
  • also log FW revision|hash check errors|warnings to console
@Lemonexe Lemonexe added bug Something isn't working as expected sentry Reports linked from Sentry.io or Sentry enhancements labels Jan 24, 2025
@Lemonexe Lemonexe self-assigned this Jan 24, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jan 24, 2025
@Lemonexe Lemonexe mentioned this issue Jan 24, 2025
Merged
@Lemonexe Lemonexe moved this from 🎯 To do to 🔎 Needs review in Suite Desktop Jan 24, 2025
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Desktop Jan 27, 2025
This was referenced Jan 28, 2025
Merged
Merged
@bosomt
Copy link
Contributor

bosomt commented Jan 28, 2025

QA OK

Image
  • Suite version: desktop 25.2.0 (4ee0ed9)

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lemonexe Lemonexe

Labels
bug Something isn't working as expected sentry Reports linked from Sentry.io or Sentry enhancements
Projects
Suite Desktop
Status: ✅ Approved
Milestone
No milestone
2 participants
@Lemonexe @bosomt