Skip to content

TxDetail - XRP - Display destination tag #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sorooris opened this issue Feb 10, 2021 · 3 comments · Fixed by #16634
Closed

TxDetail - XRP - Display destination tag #3375

sorooris opened this issue Feb 10, 2021 · 3 comments · Fixed by #16634
Assignees
@izmy
Labels
altcoins not related to bitcoin feature Product related issue visible for end user Ripple XRP

Comments

@sorooris
Copy link
Contributor

sorooris commented Feb 10, 2021 •
edited
Loading

Describe the bug
Transaction detail modal does not display its destination tag.

Info:

  • Suite Version: web 20f555f
  • Browser: Chromium 88.0.4324.150
  • OS: NixOS 20.09
  • Firmware Version: model T 2.3.5 ffa96205f

Steps to reproduce:

  1. Create and send an arbitrary XRP transaction with destination tag filled in,
  2. Select and display the transaction detail,
  3. Observe modal.

Expected result:
Modal displays the destination tag that was added.

Actual result:
Modal doesn't include destination tag.

Screenshots:
image
image
@sorooris sorooris added the bug Something isn't working as expected label Feb 10, 2021
@slowbackspace
Copy link
Contributor

slowbackspace commented Feb 10, 2021 •
edited
Loading

More like feature request! :)

cc @matejzak Where do you wanna put it? Maybe it could be done at once together with some ETH specific things we could want to show?

@alex-jerechinsky alex-jerechinsky added Feature request feature Product related issue visible for end user and removed bug Something isn't working as expected labels Feb 17, 2021
@alex-jerechinsky alex-jerechinsky changed the title TxDetail - XRP - Destination tag not displayed TxDetail - XRP - Display destination tag Feb 17, 2021
@hynek-jina hynek-jina removed the MEDIUM label Jun 8, 2022
@hynek-jina hynek-jina added the altcoins not related to bitcoin label Jul 22, 2022
@tomasklim
Copy link
Member

tomasklim commented May 4, 2024 •
edited
Loading

Screenshot 2024-05-04 at 20 27 32

Add it to mined time and tx id. Let's use fingerprint icon

@tomasklim tomasklim moved this to 🎯 To do in Suite Desktop Dec 29, 2024
@tomasklim tomasklim assigned TomasBoda and unassigned enjojoy Jan 9, 2025
@tomasklim tomasklim assigned izmy and unassigned TomasBoda Jan 21, 2025
@tomasklim tomasklim added the Ripple XRP label Jan 21, 2025
@izmy izmy mentioned this issue Jan 27, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 30, 2025
@bosomt
Copy link
Contributor

bosomt commented Feb 3, 2025

QA OK

Info:

  • Suite version: web 25.2.0 (e948e70)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.8 regular (revision bbcb920213b0ab847a2fedf825eac70652e33279)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izmy izmy

Labels
altcoins not related to bitcoin feature Product related issue visible for end user Ripple XRP
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TxDetail - XRP - Display destination tag trezor/trezor-suite
10 participants
@izmy @slowbackspace @sorooris @hynek-jina @matejzak @bosomt @tomasklim @TomasBoda @alex-jerechinsky @enjojoy