Skip to content

Ripple memo / destination tag in send and receive form #16513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomasklim opened this issue Jan 21, 2025 · 1 comment · Fixed by #16621
Closed

Ripple memo / destination tag in send and receive form #16513

tomasklim opened this issue Jan 21, 2025 · 1 comment · Fixed by #16621
Assignees
Labels

Comments

@tomasklim
Copy link
Member

tomasklim commented Jan 21, 2025

Improve UI of Destination tag and and rename it to Memo/Destination tag

Problems

  • Destination tag field is hard to find and confusing to users(feedback from users)

Requirements

  • Send form
    • update the destination tag UI according to the following design: https://www.figma.com/design/jsdvZlsY36rCc1E6PoItcz/Global-actions?node-id=4359-12035&t=nb8QE71sYXymuNNy-1
    • make the destination tag input visible without clicking
    • add a toggle button to disable the destination tag input
    • If the toggle is enabled (default state) - the destination tag input field should be required if the toggle button is on. Users cannot proceed further with send without including the destination tag.
    • if the toggle button is disabled - then the input for destination tag should be hidden and the field should no longer be required. instead of the input we should display the warning message (see design file)
  • Receive form
    • display an info banner about the destination tag on top of the receive form
@tomasklim tomasklim added the Ripple XRP label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jan 21, 2025
@tomasklim tomasklim assigned izmy, rojcyk and jirih-stsh and unassigned rojcyk and jirih-stsh Jan 21, 2025
@jirih-stsh jirih-stsh changed the title Ripple memo / destination tag send form Ripple memo / destination tag in send and receive form Jan 29, 2025
@jirih-stsh jirih-stsh moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Jan 29, 2025
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Jan 30, 2025
@bosomt
Copy link
Contributor

bosomt commented Feb 3, 2025

QA OK

  • Add Memo/Destination tag switch present
  • Memo/Destination tag isn't a number detected
  • 10 chars maximum
  • im not allowed to send/sign tx if enabled and not filled in tag /but there is no warning why im not allowed to send tx,/
  • ❌ i have to enter and remove tag number to get Destination tag isn't set not sure if its worth follow up issue @tomasklim
Image

Info:

  • Suite version: web 25.2.0 (b5a2602)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.8 regular (revision bbcb920213b0ab847a2fedf825eac70652e33279)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants