Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Welcome screen #13261

Closed
jvaclavik opened this issue Jul 10, 2024 · 6 comments · Fixed by #13333, #13349, #13355, #13369 or #13415
Closed

Polish Welcome screen #13261

jvaclavik opened this issue Jul 10, 2024 · 6 comments · Fixed by #13333, #13349, #13355, #13369 or #13415
Assignees
@hstastna

Comments

@jvaclavik
Copy link
Contributor

jvaclavik commented Jul 10, 2024 •
edited
Loading

  1. Check main button color - should be variant="primary"

  2. There are multiple responsive issues:

image

image

  1. Verify design with Ondra
@hstastna
Copy link
Contributor

hstastna commented Jul 10, 2024 •
edited
Loading

I think there are more places in Suite with the same overflow problem (especially with big zoom and small window size):
wdyt

@matejkriz
Copy link
Member

One more important for us now (as we will navigate users from Suite Lite to mobile Suite Web for onboarding) 🙏 :
image

@matejkriz matejkriz mentioned this issue Jul 10, 2024
Merged
@hstastna hstastna mentioned this issue Jul 15, 2024
Merged
@hstastna
Copy link
Contributor

image

hstastna added a commit that referenced this issue Jul 15, 2024
@hstastna
fix(suite): Make final onboarding step more responsible (#13261)
3cc6dfe
@hstastna hstastna mentioned this issue Jul 15, 2024
Merged
hstastna added a commit that referenced this issue Jul 15, 2024
@hstastna
fix(suite): Make final onboarding step more responsible (#13261)
f678d26
@hstastna hstastna reopened this Jul 15, 2024
@hstastna hstastna reopened this Jul 15, 2024
hstastna added a commit that referenced this issue Jul 15, 2024
@hstastna
fix(suite): Make Receive, Buy Buttons more responsive (#13261)
a2cc970
@hstastna hstastna mentioned this issue Jul 15, 2024
Merged
hstastna added a commit that referenced this issue Jul 16, 2024
@hstastna
fix(suite): Make Receive, Buy Buttons more responsive (#13261)
ea94b28
@hstastna hstastna reopened this Jul 16, 2024
hstastna added a commit that referenced this issue Jul 16, 2024
@hstastna
fix(suite): Make Install firmware buttons more rensposive (#13261)
6d91f33
@hstastna hstastna mentioned this issue Jul 16, 2024
Merged
hstastna added a commit that referenced this issue Jul 17, 2024
@hstastna
fix(suite): Make Install firmware buttons more rensposive (#13261)
31625f0
@jvaclavik
Copy link
Contributor Author

One more screen. Can you please take a look @hstastna? 🙏

image

@hstastna hstastna reopened this Jul 18, 2024
@hstastna
Copy link
Contributor

Need to adjust view only promo content related screen, hence reopening the issue.

hstastna added a commit that referenced this issue Jul 18, 2024
@hstastna
fix(suite): Make view only promo content screen more responsible (#13261
97e0ce0 
)
@hstastna hstastna mentioned this issue Jul 18, 2024
Merged
hstastna added a commit that referenced this issue Jul 18, 2024
@hstastna
fix(suite): Make view only promo content screen more responsible (#13261
c48bd06 
)
hstastna added a commit that referenced this issue Jul 18, 2024
@hstastna
fixup! fix(suite): Make view only promo content screen more responsib…
af5a821 
…le (#13261)
hstastna added a commit that referenced this issue Jul 22, 2024
@hstastna
fixup! fixup! fix(suite): Make view only promo content screen more re…
4f6e0df 
…sponsible (#13261)
hstastna added a commit that referenced this issue Jul 23, 2024
@hstastna
fix(suite): Make view only promo content screen more responsible (#13261
7e4a244 
)
hstastna added a commit that referenced this issue Jul 23, 2024
@hstastna
fix(suite): Make view only promo content screen more responsible (#13261
48af875 
)
@bosomt
Copy link
Contributor

bosomt commented Aug 1, 2024

QA OK

Info:

  • Suite version: web 24.8.0 (96da7b9)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 bitcoin-only (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hstastna hstastna

Labels
None yet
Projects
Issues Suite
Status: ✅ Approved
Milestone
No milestone
4 participants
@jvaclavik @matejkriz @hstastna @bosomt