Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction history - ERC20 tokens not included in search #3544

Closed
Tracked by #12165
bosomt opened this issue Mar 15, 2021 · 3 comments · Fixed by #13410
Closed
Tracked by #12165

Transaction history - ERC20 tokens not included in search #3544

bosomt opened this issue Mar 15, 2021 · 3 comments · Fixed by #13410
Assignees
@AdamSchinzel
Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user transactions Transaction history page
Milestone
Suite Trends H1/2024

Comments

@bosomt
Copy link
Contributor

bosomt commented Mar 15, 2021

Describe the bug
When you look in Ethereum transaction history ERC20 tokens are not included in search.

Steps to reproduce:

  1. Load account that includes ERC20 token transactions
  2. Search for those transaction via search field
  3. Observe

Info:

  • Suite version: web 21.4.0 (1da73bf)
  • Browser: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: model T 2.3.5 regular

Expected result:
When you look in Ethereum transaction history ERC20 tokens are included in search.

Actual result:
When you look in Ethereum transaction history ERC20 tokens are not included in search.

Screenshots:
image

image

image
@keraf
Copy link
Contributor

keraf commented Mar 15, 2021

Symbol names cannot be searched yet but I think it would be good to support that for tokens. I guess we can probably use a prefix to specifically return certain tokens (for example: token:TUSD). We could even pre-fill the search by clicking on that token. cc @matejzak @alex-jerechinsky @tsusanka

@bosomt bosomt changed the title Transaction history - ERC20 tokens not included in seach Transaction history - ERC20 tokens not included in search May 15, 2021
@matejzak matejzak added LOW transactions Transaction history page labels Sep 14, 2021
@hynek-jina hynek-jina added the feature Product related issue visible for end user label Dec 16, 2021
@hynek-jina hynek-jina removed the LOW label Jun 8, 2022
@hynek-jina hynek-jina added altcoins not related to bitcoin ERC20 labels Jul 23, 2022
@AdamSchinzel AdamSchinzel added EVM Issues related to networks based on Ethereum Virtual Machine and removed ERC20 labels Jan 23, 2024
@tomasklim tomasklim added this to the Suite Trends H1/2024 milestone Jan 23, 2024
@AdamSchinzel AdamSchinzel mentioned this issue Jan 24, 2024
Closed
@tomasklim tomasklim removed the altcoins not related to bitcoin label Jan 24, 2024
@tomasklim tomasklim mentioned this issue Jun 11, 2024
Closed
@tomasklim tomasklim mentioned this issue Jul 2, 2024
Open
@AdamSchinzel AdamSchinzel mentioned this issue Jul 18, 2024
Merged
@bosomt
Copy link
Contributor Author

bosomt commented Jul 24, 2024

Not sure if expected

see this transaction

when i look for 0x40ec5B33f54e0E8A33A975908C5BA1c14e5BbbDf i dont see this transaction

image image

Info:

  • Suite version: web 24.8.0 (986032c)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link
Contributor Author

bosomt commented Jul 24, 2024 •
edited
Loading

QA OK

  • above fixed in different PR
  • im able to search and find by token name
  • im able to search and find by token contract
  • im able to search and find by send address
  • im able to search and find by receive address
  • tested on ADA ETH ETC SOL

Info:

  • Suite version: web 24.8.0 (78027d7)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.0 regular (revision dd4671a5104952ef505d28d1f9e94d1484b4607a)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamSchinzel AdamSchinzel

Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user transactions Transaction history page
Projects
Issues Suite
Archived in project
Milestone
Suite Trends H1/2024
Development

Successfully merging a pull request may close this issue.

fix(suite): transaction search with token name, symbol or contract trezor/trezor-suite
7 participants
@hynek-jina @matejzak @keraf @bosomt @tomasklim @AdamSchinzel @alex-jerechinsky