Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No instruction to Swipe up after changing brightness T3T1 #4261

Closed
evgenysl opened this issue Oct 15, 2024 · 2 comments · Fixed by #4279
Closed

No instruction to Swipe up after changing brightness T3T1 #4261

evgenysl opened this issue Oct 15, 2024 · 2 comments · Fixed by #4279
Labels
bug Something isn't working as expected low hanging fruit Simple, quick task.

Comments

@evgenysl
Copy link

evgenysl commented Oct 15, 2024 •
edited
Loading

Describe the bug
In order to confirm brightness changes on Trezor, user needs to Swipe up, but no instructions are provided.

This photo is after change was made with horizontal slider:

IMG_6879

User can still swipe up to continue, but he needs to guess this is a correct next step.

Info:

  • Suite version: desktop 24.10.1 (3cbe786b5c8effd03b331faec20a41ef01d6671b)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.10.1 Chrome/126.0.6478.234 Electron/31.6.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.3 regular (revision 7f373ae)
  • Transport: BridgeTransport 2.0.33

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings -> Device -> Change brightness
  2. On Trezor, swipe horizontally to adjust brightness
  3. No Swipe up instructions appear at the bottom.

Expected behavior
After brightness was changed with slider, Adjust Swipe horizontally instructions should change to Swipe up

Figma:

Screenshot 2024-10-15 at 15 20 34
@evgenysl evgenysl added the bug Something isn't working as expected label Oct 15, 2024
@Hannsek Hannsek moved this to 🎯 To do in Firmware Oct 15, 2024
@Hannsek Hannsek added the low hanging fruit Simple, quick task. label Oct 23, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Oct 23, 2024

I guess @bieleluk can take a look? What do you think Lukas?

@bieleluk bieleluk mentioned this issue Oct 23, 2024
Merged
@obrusvit obrusvit moved this from 🎯 To do to 🔎 Needs review in Firmware Oct 24, 2024
@evgenysl
Copy link
Author

evgenysl commented Nov 5, 2024

Device: Trezor T3T1 2.8.4 regular (revision d884dae)
QA OK

@evgenysl evgenysl moved this from 🔎 Needs review to ✅ Approved in Firmware Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected low hanging fruit Simple, quick task.
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core/rust) Handle touchStop event in brightess dialog bieleluk/trezor-firmware
2 participants
@Hannsek @evgenysl