Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of the xpub displaying should be aligned with address displaying #3047

Closed
Hannsek opened this issue May 31, 2023 · 5 comments · Fixed by #3177
Closed

Behaviour of the xpub displaying should be aligned with address displaying #3047

Hannsek opened this issue May 31, 2023 · 5 comments · Fixed by #3177
Assignees
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.

Comments

@Hannsek
Copy link
Contributor

Hannsek commented May 31, 2023

trezor/trezor-suite#3454 (comment)

xpub qr code under i button, missing x -> xpub mismatch?

@Hannsek Hannsek added this to Firmware May 31, 2023
@Hannsek Hannsek added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label May 31, 2023
@Hannsek
Copy link
Contributor Author

Hannsek commented Jun 1, 2023

Probably related: #3043

@bosomt
Copy link

bosomt commented Jun 7, 2023

Checked it with latest version 23.6.1 that will be soon released and it does not show complete xpub address when address is too long.
problematic coins are:
Cardano Ada and Bitcoin taproot address.

Model One via confirm button you are navigated to rest of XPUB characters
Model T shows first part of xpub and rest is ignored so if you only check last charasters of XPUB it wont match when compared with Trezor Suite.

image

@Hannsek Hannsek added this to the Firmware 2.6.1 release milestone Jun 12, 2023
@Hannsek Hannsek moved this to 🎯 To do in Firmware Jun 12, 2023
@mmilata mmilata moved this from 🎯 To do to 🏃‍♀️ In progress in Firmware Jul 24, 2023
@mmilata
Copy link
Member

mmilata commented Jul 24, 2023

I can confirm the Cardano issue but not the taproot one. Can somebody please provide steps to make trezor display truncated taproot XPUB?

The old UI did not show QR code for XPUBs, I'll see if it can be added such that it's scanable.

@bosomt
Copy link

bosomt commented Jul 26, 2023

Checked it one more time /multiple accounts + testnet/ and Bitcoin taproot XPUB is displayed correctly /except prefix missing / sorry for confusion.

tr([2c27fa4b/86'/0'/0']xpub6BvdKTJruDymKUqK7wm9q3NsieBnNzjeYEC6ik25wPLY5aR3A34TQhJtfnegRTZmWPbcaBbB1NphhnfiSz3EXmU4uKqkx9BaiCr9d8q5DSS/<0;1>/*)

vs

xpub6BvdKTJruDymKUqK7wm9q3NsieBnNzjeYEC6ik25wPLY5aR3A34TQhJtfnegRTZmWPbcaBbB1NphhnfiSz3EXmU4uKqkx9BaiCr9d8q5DSS

@mmilata
Copy link
Member

mmilata commented Jul 26, 2023

I see, thanks. That is more under the scope of #1888, though if I understand correctly there's no non-descriptor taproot format in use, so we may want to increase priority of that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants