Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559 transactions on TT do not require hold 5 seconds to confirm #2020

Closed
yura-pakhuchiy opened this issue Dec 15, 2021 · 2 comments · Fixed by #2103
Closed

EIP-1559 transactions on TT do not require hold 5 seconds to confirm #2020

yura-pakhuchiy opened this issue Dec 15, 2021 · 2 comments · Fixed by #2103
Assignees
Labels
bug Something isn't working as expected

Comments

@yura-pakhuchiy
Copy link
Contributor

Transaction is confirmed immediately after user confirms totals fees. This is different from how confirmations works for legacy ETH transactions and for other coins and may lead to confirmation of unwanted transaction, due to user may expect one more screen for final confirmations, or due to poor quality touchscreen in TT (mine sometimes registers click in wrong location or double clicks instead of single click).

@yura-pakhuchiy yura-pakhuchiy added the bug Something isn't working as expected label Dec 15, 2021
@hynek-jina hynek-jina added feature Product related issue visible for end user and removed bug Something isn't working as expected labels Dec 15, 2021
@matejcik matejcik added bug Something isn't working as expected and removed feature Product related issue visible for end user labels Dec 15, 2021
@bosomt
Copy link

bosomt commented Dec 25, 2021

QA NOK

tested by
trezorctl eth sign-tx -n "m/44'/60'/0'/0/0" -e 2 --nonce 1234567890 --gas-limit 123 --max-gas-fee 234 --max-priority-fee 456 0x27b1fdb04752bbc536007a920d24acb045561c26 4000

yes there ara only confirmation screens but not hold to confirm screen
https://photos.app.goo.gl/BQrTtSYqzyqpd3St7

device 2.4.3 fw public revison 595b142

@bosomt
Copy link

bosomt commented Feb 14, 2022

QA OK

hold to confirm displayed during
trezorctl eth sign-tx -n "m/44'/60'/0'/0/0" -e 2 --nonce 1234567890 --gas-limit 123 --max-gas-fee 234 --max-priority-fee 456 0x27b1fdb04752bbc536007a920d24acb045561c26 4000

FW version : trezor-fw-regular-2.4.4-d979efc3.bin 0xd979efc3cac49ce3c3ee99ce4dbba6e6217844d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
4 participants