Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination for sign/verify #1271

Closed
tsusanka opened this issue Sep 18, 2020 · 3 comments
Closed

Add pagination for sign/verify #1271

tsusanka opened this issue Sep 18, 2020 · 3 comments
Assignees
@matejcik
Labels
altcoin Any non-Bitcoin coins bitcoin Bitcoin related
Milestone
21.02

Comments

@tsusanka
Copy link
Contributor

Instead of truncating the message. We should introduce some upper limit though. Related: #1014
@tsusanka tsusanka added this to the backlog milestone Sep 18, 2020
@prusnak prusnak added altcoin Any non-Bitcoin coins bitcoin Bitcoin related labels Sep 18, 2020
@tsusanka
Copy link
Contributor Author

Related to #436.

@tsusanka tsusanka modified the milestones: backlog, 2020-11 Oct 1, 2020
@mmilata mmilata self-assigned this Oct 29, 2020
@mmilata mmilata mentioned this issue Nov 4, 2020
Closed
@tsusanka tsusanka modified the milestones: 2020-11, 2020-12 Nov 6, 2020
@tsusanka tsusanka modified the milestones: 2020-12, 2021-01 Nov 20, 2020
@tsusanka tsusanka modified the milestones: 2021-01, 2021-02 Dec 28, 2020
matejcik added a commit that referenced this issue Jan 11, 2021
@matejcik
docs(core): update changelog for #1271/#1384
2cb10ce
matejcik added a commit that referenced this issue Jan 11, 2021
@matejcik
docs(core): update changelog for #1271/#1384
ebc67c9
matejcik added a commit that referenced this issue Jan 11, 2021
@matejcik
docs(core): update changelog for #1271/#1384
58708cd
@mmilata
Copy link
Member

mmilata commented Jan 13, 2021

Pagination implemented in #1384. How to proceed with the field limit?

@mmilata mmilata assigned matejcik and unassigned mmilata Jan 14, 2021
@mmilata
Copy link
Member

mmilata commented Jan 14, 2021

As discussed on standup, limit won't be introduced.

@mmilata mmilata closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
altcoin Any non-Bitcoin coins bitcoin Bitcoin related
Projects
None yet
Milestone
21.02
Development

Successfully merging a pull request may close this issue.

Enable pagination for sign/verify message trezor/trezor-firmware
4 participants
@prusnak @mmilata @matejcik @tsusanka