Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple change-outputs #1098

Closed
andrewkozlik opened this issue Jul 7, 2020 · 0 comments · Fixed by #1100
Closed

Support multiple change-outputs #1098

andrewkozlik opened this issue Jul 7, 2020 · 0 comments · Fixed by #1100
Assignees
Labels
bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1. T1B1 legacy Trezor One
Milestone

Comments

@andrewkozlik
Copy link
Contributor

Both T1 and TT firmware allow having only one change-output per transaction. If there are multiple change-outputs, then only the first one is treated accordingly and the remaining ones are treated as normal outputs, i.e. they are shown for confirmation and included in the total amount. The reason why this restriction was put in place was historically the lack of a use-case for multiple change-outputs and the risk of malware fragmenting the change over hundreds of outputs.

As new use-cases are emerging, we want to allow multiple change-outputs in a transaction. All outputs that are being returned to the same account as the one from which the inputs originate will not be shown for confirmation and will not be included in the total amount. To mitigate the attack mentioned above, a warning screen will be shown before signing the transaction whenever there are more than two change-outputs.

See also spesmilo/electrum#2440.

@andrewkozlik andrewkozlik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T1B1 legacy Trezor One bitcoin Bitcoin related enhancement labels Jul 7, 2020
@andrewkozlik andrewkozlik self-assigned this Jul 7, 2020
@prusnak prusnak added this to the 2020-08 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1. T1B1 legacy Trezor One
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants