Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed25519-donna refactoring #20

Closed
onvej-sl opened this issue Sep 3, 2018 · 1 comment
Closed

ed25519-donna refactoring #20

onvej-sl opened this issue Sep 3, 2018 · 1 comment
Labels
crypto Stand-alone cryptography library used by both Trezor Core and the Trezor Legacy firmware

Comments

@onvej-sl
Copy link
Contributor

onvej-sl commented Sep 3, 2018

It's pain to write code using ed25519-donna since:

  • It's a one-purpose library aiming only at signing, verifying and performing Diffie-Hellman key exchange.
  • It has almost no abstraction for other functions (especially for private and public key operations).
  • It uses several number and point representations.
  • It's badly documented. In particular, it's not clear what representations of inputs and outputs of functions are used.
  • It's difficult to review any code using the library.

I suggest creating a well-documented abstraction for private and public key operations.

@trezor trezor deleted a comment from ph4r05 Sep 3, 2018
@trezor trezor deleted a comment from onvej-sl Sep 3, 2018
@trezor trezor deleted a comment from ph4r05 Sep 3, 2018
@prusnak prusnak transferred this issue from trezor/trezor-crypto Apr 16, 2019
@prusnak prusnak added this to the backlog milestone Apr 16, 2019
@prusnak prusnak added the crypto Stand-alone cryptography library used by both Trezor Core and the Trezor Legacy firmware label Apr 16, 2019
@ZdenekSL
Copy link
Contributor

Out of scope for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Stand-alone cryptography library used by both Trezor Core and the Trezor Legacy firmware
Projects
None yet
Development

No branches or pull requests

3 participants