Skip to content

Commit c0474b1

Browse files
committed
Beefed up unit test.
1 parent c404bdd commit c0474b1

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

core/src/main/scala/org/apache/spark/util/JsonProtocol.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,6 @@ private[spark] object JsonProtocol {
471471

472472
def stageInfoFromJson(json: JValue): StageInfo = {
473473
val stageId = (json \ "Stage ID").extract[Int]
474-
val stageAttempt = (json \ "Attempt").extractOpt[Int].getOrElse(1)
475474
val stageName = (json \ "Stage Name").extract[String]
476475
val numTasks = (json \ "Number of Tasks").extract[Int]
477476
val rddInfos = (json \ "RDD Info").extract[List[JValue]].map(rddInfoFromJson)

core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,10 +270,12 @@ class JsonProtocolSuite extends FunSuite {
270270
private def assertEquals(info1: TaskInfo, info2: TaskInfo) {
271271
assert(info1.taskId === info2.taskId)
272272
assert(info1.index === info2.index)
273+
assert(info1.attempt === info2.attempt)
273274
assert(info1.launchTime === info2.launchTime)
274275
assert(info1.executorId === info2.executorId)
275276
assert(info1.host === info2.host)
276277
assert(info1.taskLocality === info2.taskLocality)
278+
assert(info1.speculative === info2.speculative)
277279
assert(info1.gettingResultTime === info2.gettingResultTime)
278280
assert(info1.finishTime === info2.finishTime)
279281
assert(info1.failed === info2.failed)

0 commit comments

Comments
 (0)