Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream queries #133

Closed
savq opened this issue Mar 29, 2024 · 2 comments · Fixed by #147
Closed

Upstream queries #133

savq opened this issue Mar 29, 2024 · 2 comments · Fixed by #147
Labels
enhancement New feature or request

Comments

@savq
Copy link
Collaborator

savq commented Mar 29, 2024

Treesitter v0.21.0 made last-wins precedence the default, meaning tree-sitter queries now work in the same order as nvim /helix queries.

nvim-treesitter also renamed some captures to align with tree-sitter and helix.

This means maintaining a common set of queries is much easier now, it would reduce some duplicated efforts between editors, and also make it easier to handle breaking changes downstream.

@savq savq added the enhancement New feature or request label Mar 29, 2024
@clason
Copy link

clason commented Apr 1, 2024

Nit: Helix is still using the old first-wins precedence; efforts to change are underway but going (very) slowly.

EDIT I think the support is already there, it's just that the queries haven't been adjusted yet.

@savq
Copy link
Collaborator Author

savq commented May 4, 2024

Someone had already opened a PR in helix to update the julia queries, including the precedence. See helix-editor/helix#10031. I assume that'll get merged when helix switches. So it'll be easy for them to follow upstream too.

oh-yeah-its-all-coming-together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants