overflow risk in ioctl.cpp

[mjmeehan]

cmd in ioctl.cpp is an int, but the case variables (FS_IOC_GETFLAGS and FS_IOC_SETFLAGS) are longs.

[trapexit]

FUSE's callback signature for ioctl is:

int (*ioctl) (const char *, int cmd, void *arg, struct fuse_file_info *, unsigned int flags, void *data);

The man page on my Ubuntu 14.04LTS machine indicates:

int ioctl(int d, int request, ...);

http://man7.org/linux/man-pages/man2/ioctl.2.html indicates it's an unsigned long.

Sounds like a fuse issue. Nothing I can do about it. I'm given an int.

Also... the header also sets FS_IOC32_GETFLAGS as an int. So it seems unlikely the value is larger than such.

Need to see how switch does value promotion for comparison.

[trapexit]

GCC warns with "overflow in implicit constant conversion" if the value had been an issue. I'll put in an explicit cast just in case.