Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Google Picker API #5382

Closed
mifi opened this issue Aug 1, 2024 · 4 comments · Fixed by #5443
Closed

Implement Google Picker API #5382

mifi opened this issue Aug 1, 2024 · 4 comments · Fixed by #5443
Assignees
Labels

Comments

@mifi
Copy link
Contributor

mifi commented Aug 1, 2024

Problem

Google Drive scope drive.readonly which we currently use has become restricted, meaning google requires strict validation in order to use this scope. This includes security assessments from a third-party companies.

It's clear that Google wants to push vendors over to the Picker API instead.

Solution

Use the recommended/non-sensitive drive.file scope instead. The problem is that this scope requires us to use a completely different API, as well as Google's UI to pick files.

drive.file: Create new Drive files, or modify existing files, that you open with an app or that the user shares with an app while using the Google Picker API or the app's file picker.

Alternatives

Not that I know of, other than dropping Drive support or keeping the existing implementation

References

Discussion

There's some old code that seems to support Google Picker with Photos, but the demo app is blocked by google.

Note that Google Photos scope https://www.googleapis.com/auth/photoslibrary.readonly is restricted and also requires verification. There doesn't seem to be any way of getting Google Photos in the Google Picker API.

@mifi mifi added the Feature label Aug 1, 2024
@mifi mifi mentioned this issue Sep 2, 2024
15 tasks
@GFoley83
Copy link

GFoley83 commented Dec 2, 2024

@mifi Just confirming that until this is resolved, using the hosted version of Companion for Google Drive and Google Photos won't work currently? Assuming that is also why the Google options are greyed out on the examples page:
https://uppy.io/examples

@mifi
Copy link
Contributor Author

mifi commented Dec 2, 2024

that's correct. we hope to have this feature merged this week

@mifi mifi closed this as completed in #5443 Dec 2, 2024
@devincowan
Copy link

@mifi thank you for this! We have been stymied by the 3rd party Oauth verification process with Google and it looks like the Picker will get us unstuck. Any plans for a release?

@Murderlon
Copy link
Member

We'll release it today or tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants