Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Uppy events on failed upload #403

Closed
richardwillars opened this issue Oct 27, 2017 · 4 comments
Closed

Inconsistent Uppy events on failed upload #403

richardwillars opened this issue Oct 27, 2017 · 4 comments

Comments

@richardwillars
Copy link
Contributor

If I upload one file and it fails to upload Uppy does not emit a core:success event.
If I upload two files (one of which fails and one succeeds then it emits a core:success) event.

I would suggest that the core:success event fires at the end of the upload attempt, regardless of whether the files failed to upload or not. It's difficult having an inconsistency and knowing when the upload attempt has actually finished.

@goto-bus-stop
Copy link
Contributor

Yeah, I agree. I've been working on making upload() return an object with { failed, successful } arrays, we could then emit core:complete with that object and remove the core:success event.

@richardwillars
Copy link
Contributor Author

Oh awesome, that's a nice solution! Do you have any sort of timescale on it getting release just so I can plan my work around it?

@goto-bus-stop
Copy link
Contributor

Currently aiming to get it in 0.21 which is planned for release on november 10.

@goto-bus-stop
Copy link
Contributor

the core:complete event and upload() → {successful, failed} patch landed in 0.21 last week—blog post is coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants