Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showRemoveButtonAfterComplete breaks dashboard styling #3308

Open
Murderlon opened this issue Nov 9, 2021 · 5 comments
Open

showRemoveButtonAfterComplete breaks dashboard styling #3308

Murderlon opened this issue Nov 9, 2021 · 5 comments
Labels

Comments

@Murderlon
Copy link
Member

The remove button is on top of the progress icon. Surfaced in #3305.

Capture d’écran 2021-11-09 à 12 08 37

@arturi
Copy link
Contributor

arturi commented Nov 15, 2021

We could hide the complete checkmark when showing remove button, but what if we need to indicate the file that can be removed is uploaded, @nqst? Should we move the checkmark to the center?

@nqst
Copy link
Contributor

nqst commented Nov 15, 2021

Should we move the checkmark to the center?

I like this idea, yeah. I'd limit such an appearance for that particular case only, though.

Quick sketch:

@arturi
Copy link
Contributor

arturi commented Nov 17, 2021

I'd limit such an appearance for that particular case only, though

Every time new conditions come up, I think about supporting it and having if if if if if if or ? : '' and special .uppy-Dashboard--has-showRemoveButtonAfterComplete CSS stuff, not to mention separate SVGs that make Uppy larger. This is a general concern, not necessarily big deal in this case.

@stale
Copy link

stale bot commented Nov 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Old issues that haven't had activity recently label Nov 19, 2022
@Murderlon Murderlon removed the Stale Old issues that haven't had activity recently label Nov 19, 2022
@arturi arturi removed the Dashboard label Apr 12, 2023
@fnimick
Copy link

fnimick commented Mar 18, 2024

I use the following CSS to move the indicator to the upper left (or right, for rtl) of the image displayed, so it doesn't collide with the action button.

.uppy-Dashboard-Item .uppy-Dashboard-Item-progress {
    left: 0;
    right: 0;
    display: flex;
    justify-content: flex-start;
    margin-left: -11px;
    margin-right: -11px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants