Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version tag to Docker builds #1107

Closed
matthewhartstonge opened this issue Oct 15, 2018 · 3 comments
Closed

Add version tag to Docker builds #1107

matthewhartstonge opened this issue Oct 15, 2018 · 3 comments
Assignees
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)

Comments

@matthewhartstonge
Copy link
Contributor

matthewhartstonge commented Oct 15, 2018

Hi team!

We are currently rolling with companion, but it's hard to know what version you are running due to using a time stamp as the container tag. As such, it would be nice to have semver tags the align with what is in the containers.

I noticed a container we lit up yesterday logged to console it's version v0.14.5-alpha.0. It would be great if your CI/CD process could tag the version as well.

uppy: 2018-10-17T03:24:57.687Z [info] jobs.cleanup.start starting clean up job
Welcome to Companion! v0.14.5-alpha.0
Listening on http://0.0.0.0:8090

From a developer perspective, this also makes it easier to know what API is running on the tin rather than having to cross reference a timestamp/load up a container to work it out.

@kvz
Copy link
Member

kvz commented Oct 16, 2018

/cc @kiloreux

@arturi arturi added the Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) label Oct 17, 2018
@kiloreux
Copy link
Contributor

#1579

@arturi
Copy link
Contributor

arturi commented May 22, 2019

Please re-open if #1579 doesn’t solve this. Thanks @kiloreux!

@arturi arturi closed this as completed Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3)
Projects
None yet
Development

No branches or pull requests

4 participants