From 0d77dd687e58397b96a841136f870cb3fc1fe7fa Mon Sep 17 00:00:00 2001 From: Ifedapo Olarewaju Date: Wed, 5 Jun 2019 17:13:51 +0100 Subject: [PATCH] companion: avoid bad mutation of file object see https://github.com/request/request/issues/2366#issuecomment-400646265 fixes #1581 --- packages/@uppy/companion/src/server/Uploader.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/@uppy/companion/src/server/Uploader.js b/packages/@uppy/companion/src/server/Uploader.js index 425552e6ac..cd3bf5b251 100644 --- a/packages/@uppy/companion/src/server/Uploader.js +++ b/packages/@uppy/companion/src/server/Uploader.js @@ -392,7 +392,6 @@ class Uploader { this.options.metadata, { [this.options.fieldname]: { - value: file, options: { filename: this.uploadFileName, contentType: this.options.metadata.type @@ -400,6 +399,10 @@ class Uploader { } } ) + // avoid setting file value through "Object.assign" + // to prevent this issue https://github.com/request/request/issues/2366#issuecomment-400646265 + formData[this.options.fieldname].value = file + const headers = headerSanitize(this.options.headers) request.post({ url: this.options.endpoint, headers, formData, encoding: null }, (error, response, body) => { if (error) {