-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use with your own server section of AWS S3 contains misleading routes #213
Comments
They are the same, it just shows that if you have an existing backend, perhaps even with existing s3 endpoints , you can just group them under |
Are you sure that only the prefix is different?
The documentation uses |
Maybe the docs are misleading, but it just needs to match. You can do this if you want: On the server: app.post('/my/supercool/endpoint', (req, res, next) => {} And then on the client: const response = await fetch('/my/supercool/endpoint', {
method: 'POST',
// Send and receive JSON.
headers: {
accept: 'application/json',
},
body: serialize({
filename: file.name,
type: file.type,
metadata,
}),
signal,
}) It's a lot of manual work. Ideally, we'd have |
Agreed, a companion compatible uploader config would be even better. I was considering this option but could not find any documentation of the current endpoints used by Companion. I can dig through the code of course but I would prefer to have it in a more readable way. |
I created two issues for it:
In the meantime if you're willing to contribute a PR to make the writing more clear in the current docs that would be great :) |
The routes provided in the "Use with your own server" of AWS S3 uploader shows different endpoints than the endpoints used in the linked "Setup Uppy" example.
uppy.io/docs/uploader/aws-s3-multipart.mdx
Lines 143 to 151 in 6a5a3bc
From the Setup Uppy example:
/sts
/sign-s3
/s3/multipart
/s3/multipart/${uploadId}
/s3/multipart/${uploadId}/${partNumber}
/s3/multipart/${uploadId}/complete
The text was updated successfully, but these errors were encountered: