Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End Time on Upcoming Dates is always 'endOfDay' for SingleDayEvents #27

Closed
lachieh opened this issue Feb 6, 2020 · 1 comment
Closed

End Time on Upcoming Dates is always 'endOfDay' for SingleDayEvents #27

lachieh opened this issue Feb 6, 2020 · 1 comment

Comments

@lachieh
Copy link
Contributor

lachieh commented Feb 6, 2020

Regardless of whether you select an end time or not, the {{ end_time }} always shows 11:59pm inside of the {{ events:upcoming }} tag.

Steps to reproduce:

  1. Create a Single Day Event and select a start and end time.
  2. Have a template that uses the {{ end_time }} value.
  3. {{ end_time }} will display as 23:59:59
@lachieh lachieh mentioned this issue Feb 6, 2020
Closed
@edalzell edalzell removed their assignment Feb 19, 2020
@sebszocinski
Copy link

This issue still occurs when using {events:calendar} or {events:in} loops and trying to access the end_time. It looks like end_time is being set in Events.php here and here.

@edalzell edalzell reopened this Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle SingleDayEvents when there is an end time
3 participants
@lachieh @sebszocinski @edalzell