Skip to content

Commit cf83fab

Browse files
cbalint13tqchen
authored andcommitted
[FFI][CMAKE] Revert cmake libbacktrace URL and update submodule (apache#18249)
* Revert the URL out from cmake for libbacktrace * Switch git submodule to upstream HEAD instead As per discussed here apache#18246 (comment), this reverts in favour of git submodule way. As per finding in the same discuss the upstream [already](https://github.com/ianlancetaylor/libbacktrace/blob/793921876c981ce49759114d7bb89bb89b2d3a2d/macho.c#L1273-L1275) incorporates [the one patch](ianlancetaylor/libbacktrace@master...tlc-pack:libbacktrace:master) used, and MacOS works fine.
1 parent c728f6e commit cf83fab

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

3rdparty/libbacktrace

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Subproject commit 08f7c7e69f8ea61a0c4151359bc8023be8e9217b
1+
Subproject commit 793921876c981ce49759114d7bb89bb89b2d3a2d

cmake/Utils/AddLibbacktrace.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ function(_libbacktrace_compile)
3333

3434
ExternalProject_Add(project_libbacktrace
3535
PREFIX libbacktrace
36-
GIT_REPOSITORY "https://github.com/ianlancetaylor/libbacktrace.git"
37-
GIT_TAG "793921876c981ce49759114d7bb89bb89b2d3a2d"
3836
SOURCE_DIR ${_libbacktrace_source}
3937
BINARY_DIR ${_libbacktrace_prefix}
4038
CONFIGURE_COMMAND

0 commit comments

Comments
 (0)