Heuristic tabstop for files with mostly spaces #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One common case of mixed indentation is when a file is written with mostly spaces and then unwittingly a few tabs with tabstop = shiftwidth < 8. To the author this may look perfectly regular but on another system with tabstop=8 the indentation does not line up as intended. Obviously this is broken in some sense, but in cases like this the intent is clear and we should heuristically detect the shiftwidth and set the tabstop to the same value.
I read some of the past discussions here on mixed indents and alternate tabstop values, and I don't think this particular pattern or solution has been covered elsewhere.
Example file that I used to observe and test this behavior: https://github.com/TheLocehiliosan/yadm/blob/e4bb8a79a4b67f447d6cdf5fda16034498a5fb27/completion/bash/yadm