Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Monix.io can no longer compile starting with Tut 0.6.4 #243

Open
alexandru opened this issue Nov 13, 2018 · 2 comments
Open

Monix.io can no longer compile starting with Tut 0.6.4 #243

alexandru opened this issue Nov 13, 2018 · 2 comments

Comments

@alexandru
Copy link

Monix.io fails compilation starting with Tut 0.6.4.

Probably related to this:

Here's a sample that is failing:

val coeval = Coeval {
  println("Effect!")
  1 + 1
}

// Nothing happens until this point:
coeval.value
//=> Effect!
// res: Int = 2

If I delete the comment at the end, then the compilation goes through. Here's the actual error:

[tut] *** Error reported at .../monix.io/_tut/docs/2x/eval/coeval.md:139: incomplete input in code block, missing brace or paren?

Note: I prefer to add my own output comments — as I don't like tut's output and that's perfectly valid Scala code. Until this is solved, I'm stuck with Tut 0.6.3.

/cc @felixmulder @ceedubs

@tpolecat
Copy link
Owner

It's valid Scala code but as far as the REPL is concerned it's incomplete because it doesn't end with an expression. I guess we could add a flag that suppresses this check?

@felixmulder
Copy link
Contributor

This is the offending line: https://github.com/tpolecat/tut/blob/series/0.6.x/modules/core/src/main/scala/tut/Tut.scala#L57 I'd say.

I agree with Rob, it's probably easiest to have a flag that doesn't care about incompleteness.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants