Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to std::future::Future #279

Closed
seanmonstar opened this issue May 6, 2019 · 2 comments
Closed

Update to std::future::Future #279

seanmonstar opened this issue May 6, 2019 · 2 comments

Comments

@seanmonstar
Copy link
Collaborator

This is a tracking issue for updating to use the stabilized std::future::Future (in Rust 1.36).

@seanmonstar
Copy link
Collaborator Author

We can start this on an std-future branch now. Any middleware wanting to use things from tokio can target it's std-future branch.

The first step is just figuring out Service::poll_ready, as that likely needs to be Pin now. However, Service::call usually wouldn't need to be Pin, as it doesn't poll a future but return one. The problem is that if a Service isn't Unpin, once you've pinned it for poll_ready, you can't get a &mut self for call.

This leads to wondering if the trait should be split somehow into Service and Ready...

@seanmonstar
Copy link
Collaborator Author

Largely done, see #367 for status of each crates release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant