Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServeDir doesn't percent-decode #114

Closed
lnicola opened this issue Aug 4, 2021 · 2 comments
Closed

ServeDir doesn't percent-decode #114

lnicola opened this issue Aug 4, 2021 · 2 comments
Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@lnicola
Copy link

lnicola commented Aug 4, 2021

Bug Report

Version

tower-http v0.1.1

Platform

Linux

Description

Uri::path() returns the original (not decoded) path. This means that ServeDir can't handle paths with e.g. spaces.
@davidpdrsn davidpdrsn added C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 4, 2021
@ttys3 ttys3 mentioned this issue Aug 26, 2021
Merged
@jplatte
Copy link
Collaborator

jplatte commented Oct 4, 2021

Was this fixed by #129?

@lnicola
Copy link
Author

lnicola commented Oct 4, 2021

I think so, yes.

@lnicola lnicola closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lnicola @davidpdrsn @jplatte